Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(sdk): Fixed documentation by updating the kfp-server-api dependency #4255

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 22, 2020

I've fixed the OpenAPI documentation generation and @Bobgy has generated the improved kfp-server-api package. However the documentation hasn't changed on the docs website since the requirements.txt was still pinning the old version.

P.S. The kfp-server-api dependency wasn't updated in #3918 and #3566 We might want to add rules to require updating requirements.in and requirements.txt when changing the dependencies.

@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 23, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy changed the title SDK - Fixed documentation by updating the kfp-server-api dependency fix(sdk) Fixed documentation by updating the kfp-server-api dependency Jul 23, 2020
@Bobgy Bobgy changed the title fix(sdk) Fixed documentation by updating the kfp-server-api dependency doc(sdk) Fixed documentation by updating the kfp-server-api dependency Jul 23, 2020
@Bobgy Bobgy changed the title doc(sdk) Fixed documentation by updating the kfp-server-api dependency doc(sdk): Fixed documentation by updating the kfp-server-api dependency Jul 23, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Jul 23, 2020

FYI, updated title.

@Bobgy
Copy link
Contributor

Bobgy commented Jul 23, 2020

Thank you for fixing this!
Can you also add automation for updating this during release so we don't miss it next time?
https:/kubeflow/pipelines/blob/22063ff88d4a459a3b60023cc82bdf3d0d0243d7/sdk/hack/release.sh

@Bobgy
Copy link
Contributor

Bobgy commented Jul 23, 2020

/lgtm

@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jul 23, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Jul 23, 2020

We need to cherry pick this to 1.0.0 branch

@jingzhang36 jingzhang36 added the cherrypicked cherry picked to release branch `release-x.y` label Aug 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs area/sdk cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants