Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Rename TrainingRuntimeRef to RuntimeRef API #2283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreyvelich
Copy link
Member

Related: #2170

Since this PR introduced ability to register custom runtimes: #2248, we decided to rename the API from TrainingRuntimeRef to RuntimeRef in TrainJob.

In the future, we are planning to support custom user runtimes (e.g. Slurm, Flux, etc.) that might use their own CRDs to orchestrate K8s resources.
The RuntimeRef API gives us more flexibility in the future and not confuse users that only TrainingRuntime and ClusterTrainingRuntime CRDs can be used.

/assign @kubeflow/wg-training-leads
/cc @ahg-g @kannon92 @danielvegamyhre @vsoch

Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: ahg-g, kannon92, danielvegamyhre, vsoch.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Related: #2170

Since this PR introduced ability to register custom runtimes: #2248, we decided to rename the API from TrainingRuntimeRef to RuntimeRef in TrainJob.

In the future, we are planning to support custom user runtimes (e.g. Slurm, Flux, etc.) that might use their own CRDs to orchestrate K8s resources.
The RuntimeRef API gives us more flexibility in the future and not confuse users that only TrainingRuntime and ClusterTrainingRuntime CRDs can be used.

/assign @kubeflow/wg-training-leads
/cc @ahg-g @kannon92 @danielvegamyhre @vsoch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant