KEP-2170: Rename TrainingRuntimeRef to RuntimeRef API #2283
+110
−110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2170
Since this PR introduced ability to register custom runtimes: #2248, we decided to rename the API from
TrainingRuntimeRef
toRuntimeRef
in TrainJob.In the future, we are planning to support custom user runtimes (e.g. Slurm, Flux, etc.) that might use their own CRDs to orchestrate K8s resources.
The
RuntimeRef
API gives us more flexibility in the future and not confuse users that onlyTrainingRuntime
andClusterTrainingRuntime
CRDs can be used./assign @kubeflow/wg-training-leads
/cc @ahg-g @kannon92 @danielvegamyhre @vsoch