-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+kubebuilder:validation:Required marker not failing #621
Comments
+1 :) |
Did you check if the same issue is reproducible with its latest version or if it is solved already? |
Currently, |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Referring to issue #599 I'd like to see the
controller-gen
tool to fail in such ambiguous situation rather than to ignore the+kubebuilder:validation:Required
marker silently. It's definitely not obvious thatomitempty
takes precedence over the kubebuilder marker and can be judged as a programming mistake in most of the cases and should be detected and reported as such.I already searched for a parameter to increase the verbosity of the tool or letting it write log file but couldn't find anything helpful so far in
controller-gen -hhh
output. Maybe there is something I missed to explore... then I would appreciate you could point me to.Example:
should break the controller-gen tool when running
make manifests
and yield an error describing the ambiguity.Environment:
Controller-gen version: v0.5.0
The text was updated successfully, but these errors were encountered: