Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support command flag completions #3163

Open
iyear opened this issue Apr 9, 2023 · 5 comments
Open

Support command flag completions #3163

iyear opened this issue Apr 9, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@iyear
Copy link

iyear commented Apr 9, 2023

What would you like to be added:

Add flag completions for kind CLI.

Why is this needed:

Many commands in kind require the setting of command flags, but there are no completions, which causes some inconvenience in use:
For example, for kind delete cluster -n, I have to use kind get clusters to get the name first. After adding flag completion, I can just auto complete the name I want.
@iyear iyear added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2023
@iyear
Copy link
Author

iyear commented Apr 9, 2023

And I'm also willing to work for it:)

@iyear
Copy link
Author

iyear commented Apr 13, 2023

Hi, any news?

@aojea
Copy link
Contributor

aojea commented Apr 13, 2023

is not already implemented? #1516

what is missing? and what is needed?

@iyear
Copy link
Author

iyear commented Apr 13, 2023 •
edited
Loading

They are basic completions. I want to be able to dynamically complete it when the flag is used. Such as kind delete cluster -n [tab][tab] and it displays all cluster names for completion.

https:/spf13/cobra/blob/main/shell_completions.md#specify-dynamic-flag-completion

@aojea
Copy link
Contributor

aojea commented Apr 13, 2023 •
edited
Loading

ok, send a PR and we see how it looks like, just only one command to evaluate it

@iyear iyear mentioned this issue Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aojea @iyear