Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve E2E Test Coverage for Webhooks (Defaulting, Validation, Conversion) and Cert-Manager CA Injection #4202

Open
camilamacedo86 opened this issue Oct 2, 2024 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. testing

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

The current e2e tests for webhooks in the Kubebuilder repository cover basic webhook creation and validation. However, several important scenarios remain untested. To ensure comprehensive coverage, we propose expanding the tests to include:

  • Defaulting Webhooks: Ensure defaulting webhooks apply resource defaults as expected.
  • Validation Webhooks: Confirm that invalid resources are rejected by validation webhooks and validation logic is enforced.
  • Conversion Webhooks: Verify conversion webhooks work when converting resources between different versions of CRDs.
  • Cert-Manager CA Injection: Ensure cert-manager correctly injects CA certificates into all webhook types (defaulting, validation, and conversion), and verify that these webhooks function properly in a cluster.

Context:
There are existing tests for webhooks, such as in:

These tests can be added under a new directory in e2e tests or, if more convenient, integrated into the existing go/v4 test suite.

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. testing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. testing
Projects
None yet
Development

No branches or pull requests

1 participant