Add support to use exisitng fips with terraform openstack #11558
+42
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds Terraform Openstack support for specifying existing floating IPs on each machine listed in
k8s_nodes
andk8s_masters
with a new optional variablereserved_floating_ip
which is only used when thefloating_ip
variable is set to true. Ifreserved_floating_ip
is not set andfloating_ip
is true, a new floating IP will be created same as before.When
reserved_floating_ip
is set, that IP will get released and not deleted when deleting all Terraform resources.Known limitations:
reserved_floating_ip
on multiple hosts, Terraform will not complain and only one machine gets assigned the IP in the end, as there is currently no check for whether or not the specific IP has already been assigned. The output will show the same IP several times as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: