Hotfix containerd restart

[fungusakafungus]

What type of PR is this?
/kind bug

What this PR does / why we need it:
It fixes containerd restart handler by preventing import_role from touching that handler.

Which issue(s) this PR fixes:
Fixes #9019

Special notes for your reviewer:

Introduced in 1781eab
Debugged by @snowmansora in #9019

Somehow, when triggering the 'restart containerd' handler from

kubespray/roles/container-engine/containerd/tasks/main.yml

Line 93 in d387d48

notify: restart containerd

, the task object still has the when condition from the previous time it was loaded by import_role from validate-container-engine.

I can't tell why include_role was changed to import_role in 1781eab, maybe @cyril-corbon can explain?

This feels like an ansible bug, but there's probably some word of caution somewhere in ansible docs...

The fix is to give import_role an empty handlers file to load, so it doesn't corrupt the handlers/main.yml. The imported tasks in tasks/reset.yml don't use any handlers themselves.

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @fungusakafungus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

Interesting find and the behaviour might be related to specific ansible versions.

However this does fix a bug and I would add it to the 2.20 milestone.

/ok-to-test
/approve

[fungusakafungus]

Created ansible issue: ansible/ansible#78871

[floryut]

/lgtm

@fungusakafungus That's a nice bugfix, thank you for opening the bug on ansible end, looking up for an answer on their end.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, fungusakafungus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment