Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code-generator to 1.30.1 #298

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 12, 2024

While working on #293, I noticed I had to bump the code-generator as well, which blew up that PR more than it should. So this PR extracts just the code-generator update.

The code generator was significantly outdated and was updated to match the current set of Kube dependencies (i.e. 1.30.x). Notably:

  • The entire GOPATH cloning logic was removed; all generators are now compatible with Go modules and there is no need anymore to ensure a GOPATH-like setup (I ran everything locally in ~/projects/prow).
  • The GOPATH magic mentions bazel peculiarities as one of the reasons for the complexity. I could not immediate see where exactly Bazel is currently used in Prow, so I simply chose to ignore it and see which wall I would hit. 😁 Bazel support seems to have been removed 2 years ago via Bazel build/test instructions are replaced with make rules kubernetes/test-infra#26039.
  • Not working in a mirrored version also fixed the bindata generation: That step never actually copied the files back to the repository and so we never noticed that someone manually fixed the %v to be %w, because go-bindata 3.1.3 (latest) still outputs %v.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xrstf
Once this PR has been reviewed and has the lgtm label, please assign timwangmusic for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2024
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 3c46998
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/670ba7c1d10710000872e894
😎 Deploy Preview https://deploy-preview-298--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xrstf
Copy link
Contributor Author

xrstf commented Oct 12, 2024

/test all

@xrstf xrstf marked this pull request as ready for review October 12, 2024 20:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants