Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke node Update only for providerID changes #132

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Invoke node Update only for providerID changes #132

merged 1 commit into from
Jan 30, 2020

Conversation

chethanv28
Copy link
Collaborator

@chethanv28 chethanv28 commented Jan 29, 2020

What this PR does / why we need it:
This PR is addressing the issue mentioned here: #131
We need to make sure nodeRegister is called only when we observe change in the ProviderID.

Which issue this PR fixes
Fixes #131

Special notes for your reviewer:

Release note:

Invoke NodeRegister only when Provider Id change is observed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @chethanv28. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2020
@chethanv28
Copy link
Collaborator Author

/assign @divyenpatel

@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2020
pkg/csi/service/cns/nodes.go Outdated Show resolved Hide resolved
pkg/csi/service/cns/nodes.go Outdated Show resolved Hide resolved
pkg/csi/service/cns/nodes.go Outdated Show resolved Hide resolved
pkg/csi/service/cns/nodes.go Outdated Show resolved Hide resolved
pkg/csi/service/cns/nodes.go Outdated Show resolved Hide resolved
@akutz
Copy link
Contributor

akutz commented Jan 29, 2020

Hi @chethanv28,

Also, the issue description needs to be updated. The fixes bit shouldn't be code-quoted or else it won't work. It should be:

Fixes #131

@akutz
Copy link
Contributor

akutz commented Jan 29, 2020

Also, it's cool to see people still use GoCSI :)

@divyenpatel
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit b29317d into kubernetes-sigs:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only call nodeRegister in nodeUpdate when node.Spec.ProviderID is changed.
4 participants