Removing hostNetwork: true setting from CSI controller and node pods #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, dvonthenen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Oct 2, 2019
gnufied
pushed a commit
to gnufied/vsphere-csi-driver
that referenced
this pull request
May 3, 2023
OCPBUGS-12718: Fix .gitattributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is removing
hostNetwork : truesetting from CSI controller and node DaemonSet pods.With this change we are also setting
dnsPolicy: "Default"for pod spec which allows pod to inherits the name resolution configuration from the node that the pods run on. Without this, when vCenter Host is specified by FQDN, pod cannot establish connection to vCenter, and results into this error -err: Post https://sc2-rdops-vm09-dhcp-60-181.eng.vmware.com:443/sdk: dial tcp: i/o timeoutThis change is required to fix concern mentioned at #68 (comment)
With this change, we will be able to merge liveness probe change made in this PR - #68
We have verified liveness probe works fine on both node DeamonSet pod and controller pod when both pods are deployed on the same node.
Which issue this PR fixes
fixes #70
Special notes for your reviewer:
With the image built from this change, @RaunakShah has also verified
csinodesis correctly populatingNode ID:with actual node names and volume is successfully getting attached to the node.Release note: