Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default VPA version to 0.13.0 #5460

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

jbartosik
Copy link
Collaborator

@jbartosik jbartosik commented Feb 1, 2023

#5355

This is for the master branch, #5462 is for the release branch

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2023
@Shubham82
Copy link
Contributor

Hi @jbartosik , just want to confirm can we merge this once the VPA 0.13.0 will officially release or should we do that before.
Because this changes reflect on master branch.

If we can do it before then please tell me i will give it LGTM.

Thanks

@kgolab
Copy link
Collaborator

kgolab commented Feb 2, 2023

Should we also change recommender-deployment-low.yaml and high files?

@Shubham82
Copy link
Contributor

Thanks @kgolab for looking at this.
I think yes, it should be part of vpa 0.13.0 release not the vpa 0.12.0. Please see the following link for vpa 0.12 release branch:
https:/kubernetes/autoscaler/tree/vpa-release-0.12/vertical-pod-autoscaler/deploy

Also it will merge after vpa 0.12.0 branch cut. Here is PR for it: #5231 as the part of the PR #4799

@Shubham82
Copy link
Contributor

I already opened a PR for it. Please find the same here: #5469

I will update it for master branch also, once vpa 0.13.0 will officially release or as per @jbartosik comments(when to do?) on this.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2023
@jbartosik
Copy link
Collaborator Author

Should we also change recommender-deployment-low.yaml and high files?

Done. I'll also update release instructions

@jbartosik jbartosik force-pushed the bump-to-vpa-0-13 branch 2 times, most recently from 558d99b to d42e009 Compare February 3, 2023 09:11
@kgolab
Copy link
Collaborator

kgolab commented Feb 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@kgolab
Copy link
Collaborator

kgolab commented Feb 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3b9c415 into kubernetes:master Feb 3, 2023
@jbartosik jbartosik deleted the bump-to-vpa-0-13 branch February 3, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants