Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Adds ProvisioningRequest v1 API client.
Special notes for your reviewer:
This PR has several commits because the process of generating client for v1 wasn't straightforward. Not squashing for transparency and future reference. I haven't found a better workaround than removing and adding
apis/
module.Steps to generate client:
k8s.io/codegen
hack/update-codegen.sh
as it was outdated (assumed/vendor
and used old scripts which no longer exist in codegen)apis/
into a regular package. Normallycluster-autoscaler/apis
is a module that can be imported standalone, but it lives withincluster-autoscaler/
, and codegen is very unhappy about it.staging/
not being a module, and instead being mirrored in a separate repo.main module (k8s.io/autoscaler/cluster-autoscaler) does not contain package k8s.io/autoscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1
.hack/update-codegen.sh
hack/update-codegen.sh
apis/
a module again (reverted second commit)Does this PR introduce a user-facing change?
/hold
/cc @MaciekPytel @mwielgus