Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s.io/cloud-provider-sample #33

Open
andrewsykim opened this issue May 20, 2019 · 13 comments
Open

Update k8s.io/cloud-provider-sample #33

andrewsykim opened this issue May 20, 2019 · 13 comments
Assignees
@andrewsykim
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. P1 Priority 1
Milestone
v1.19

Comments

@andrewsykim
Copy link
Member

A few months ago we created https:/kubernetes/cloud-provider-sample which would act as a reference implementation of the Kubernetes cloud provider (cloud-controller-manager). Since creating the repo, we haven't had a chance to update it but we should as it acts as a good reference implementation for future providers.

cc @cheftako
@andrewsykim andrewsykim changed the title Update cloud-provider-sample Update k8s.io/cloud-provider-sample May 20, 2019
@andrewsykim andrewsykim added this to the Next milestone May 20, 2019
@cheftako
Copy link
Member

I agree that we should work on this. Hands full on the apiserver-network-proxy but happy to start working on this after 1.15 code freeze.

@andrewsykim
Copy link
Member Author

Sounds good, let's p0 this for v1.16

@andrewsykim andrewsykim modified the milestones: Next, v1.16 Jul 10, 2019
@andrewsykim andrewsykim added the P2 Priority 2 label Jul 10, 2019
@andrewsykim
Copy link
Member Author

cc @timoreimann

@timoreimann
Copy link
Contributor

As discussed on the SIG meeting, integration with test grid is one of the goals here to provide a working example of a testable, basic cloud-controller-manager. This should help in-tree cloud providers making the transition going out-of-tree.

@andrewsykim andrewsykim modified the milestones: v1.16, v1.17, Next Oct 2, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timoreimann
Copy link
Contributor

@andrewsykim can we reopen?

@andrewsykim
Copy link
Member Author

/reopen
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot reopened this Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

@andrewsykim: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 23, 2020
@cheftako
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Mar 23, 2020
@andrewsykim
Copy link
Member Author

/assign

@andrewsykim andrewsykim added P1 Priority 1 and removed P2 Priority 2 labels Apr 15, 2020
@andrewsykim andrewsykim modified the milestones: Next, v1.19 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsykim andrewsykim

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. P1 Priority 1
Projects
None yet
Milestone
v1.19
Development

No branches or pull requests
5 participants
@timoreimann @cheftako @andrewsykim @k8s-ci-robot @fejta-bot