feat: add full support for labels and annotations in helm chart

[tuunit]

Motivation

For Operators like ArgoCD or Teleport it is quite useful and sometimes necessary to be able to control and insert annotations and labels into all kinds of resources and especially services.

Furthermore the documentation in the values.yaml was wrong in some places.

• The common labels and annotations aren't applied to all resources.
• Some comments mentioned the wrong resources like "Labels & Annotations for API" despite living in the "Auth" block

Description

• Remove unnecessary templating function common.tpl.renders
• Add new helper function kubernetes-dashboard.annotations to apply common annotations to all resources
• Add common app.labels to helper function kubernetes-dashboard.labels
• Add auth, api, web, and metricsScraper labels and annotation options to all their respective resources
• Add a two new options serviceLabels and serviceAnnotations to auth, api, web, and metricsScraper services

What type of PR is this?

/kind cleanup
/kind feature

[k8s-ci-robot]

Welcome @tuunit!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[tuunit]

@desaintmartin @floreks let me know what you think of this change and if I should increase the Chart version as part of this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.08%. Comparing base (2ac2758) to head (55802d2).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9490   +/-   ##
=======================================
  Coverage   37.08%   37.08%           
=======================================
  Files         283      283           
  Lines       11830    11830           
  Branches      183      202   +19     
=======================================
  Hits         4387     4387           
  Misses       7221     7221           
  Partials      222      222           

[tuunit]

/kind cleanup
/kind feature

[maciaszczykm]

@tuunit I can see you are still force pushing this branch. I started reviewing but it is hard to track changes. It would be better if you could push new commits. We do squash anyways. Let us know when it will be ready for reviews.

[tuunit]

@maciaszczykm You can review it now :) I only rebased from the main and bumped the chart version.

[maciaszczykm]

LGTM, leaving to @floreks for final approval.

[maciaszczykm]

Tested deployment locally on kind cluster, everything seems to work. Added some labels as well.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, tuunit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/kubernetes-dashboard/OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[floreks]

Great, codewise lgtm