Skip to content

Commit

Permalink
fix: address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
draveness committed Oct 12, 2019
1 parent 853432b commit fc6ff1a
Showing 1 changed file with 10 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ approvers:
editor: TBD
creation-date: 2019-10-11
last-updated: 2019-10-11
status: provisional
status: implementable
see-also:
- "https://docs.google.com/document/d/10Ch3dhD88mnHYTq9q4jtX3e9e6gpndC78g5Ea6q4JY4/edit#heading=h.dtxm02f9bgaw"
---
Expand All @@ -39,7 +39,6 @@ Ensure the TOC is wrapped with <code>&lt;!-- toc --&rt;&lt;!-- /toc --&rt;</code
- [Design Details](#design-details)
- [Test Plan](#test-plan)
- [Existing Tests](#existing-tests)
- [Needed Tests](#needed-tests)
- [Graduation Criteria](#graduation-criteria)
- [Implementation History](#implementation-history)
<!-- /toc -->
Expand All @@ -53,14 +52,14 @@ For enhancements that make changes to code or processes/procedures in core Kuber

Check these off as they are completed for the Release Team to track. These checklist items _must_ be updated for the enhancement to be released.

- [ ] kubernetes/enhancements issue in release milestone, which links to KEP (this should be a link to the KEP location in kubernetes/enhancements, not the initial KEP PR)
- [ ] KEP approvers have set the KEP status to `implementable`
- [ ] Design details are appropriately documented
- [ ] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
- [ ] Graduation criteria is in place
- [ ] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
- [x] kubernetes/enhancements issue in release milestone, which links to KEP (this should be a link to the KEP location in kubernetes/enhancements, not the initial KEP PR)
- [x] KEP approvers have set the KEP status to `implementable`
- [x] Design details are appropriately documented
- [x] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
- [x] Graduation criteria is in place
- [x] "Implementation History" section is up-to-date for milestone
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [x] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes

**Note:** Any PRs to move a KEP to `implementable` or significant changes once it is marked `implementable` should be approved by each of the KEP approvers. If any of those approvers is no longer appropriate than changes to that list should be approved by the remaining approvers and/or the owning SIG (or SIG-arch for cross cutting KEPs).

Expand Down Expand Up @@ -106,18 +105,13 @@ The major concern for graduating ScheduleDaemonSetPods to the stable version cou

ScheduleDaemonSetPods currently has multiple tests in various components that use the feature.

#### Needed Tests

As a non-optional feature, there should be a conformance test for ScheduleDaemonSetPods.

### Graduation Criteria

**Note:** *Section not required until targeted at a release.*

- [ ] Graduate ScheduleDaemonSetPods to GA
- [ ] Remove suspenedDaemonPods which handles Pod deleted on the nodes.
- [ ] Remove suspenedDaemonPods which handles Pod deleted on the nodes
- [ ] Refactor nodeShouldRunDaemonPod to remove useless return values
- [ ] Needs a conformance test
- [ ] Update documents to reflect the changes

## Implementation History
Expand Down

0 comments on commit fc6ff1a

Please sign in to comment.