-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2727 - promote grpc probes to GA #3807
Conversation
@johnbelamaric would you be my PRR approver for this? |
@SergeyKanzhelev: GitHub didn't allow me to request PR reviews from the following users: PxyUp. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a204344
to
bcd80da
Compare
/approve @bowei - I am giving you the LGTM since you are closer to it than me. |
/lgtm |
/approve |
/assign @johnbelamaric @johnbelamaric would you be ok to do PRR review for this? Good think we passed the skew problems as the beta was released in 1.24. Which makes PRR review very straightforward |
Please update the README.md to include updates to the Test Plan in the KEP template that were added in v1.25. Having this section filled out is a requirement for including the enhancement into the release. |
Co-authored-by: Mark Rossetti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SergeyKanzhelev, this needs an update to the PRR. There is a new question in the PRR questionnaire (78200cb) that needs to be added to this, and probably double check the other fields.
fe7edaa
to
619f280
Compare
Updated to the latest template. This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion in drawbacks
.
/approve from sig-net
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, johnbelamaric, SergeyKanzhelev, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* promote grpc probes to GA * Update keps/sig-node/2727-grpc-probe/kep.yaml Co-authored-by: Mark Rossetti <[email protected]> * updated to the latest template * Filled up Drawbacks --------- Co-authored-by: Mark Rossetti <[email protected]>
/sig node
/sig network
One-line PR description: promoting grpc probes to GA
Issue link: Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe #2727
Other comments:
grpc-health-probe
bin GoogleCloudPlatform/microservices-demo#1102 & https://medium.com/google-cloud/grpc-health-probes-with-kubernetes-1-24-b5bd26253a4cThe feature is ready for wide adoption