Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
The guestbook-go Dockerfile uses a relatively out of date version of golang, especially since it uses
go get
instead of modules andgo install
. This updates the base image and switches to a module-based build.Fixes #540
I am currently awaiting CNCF-CLA Approval but I have already signed the docs and permitted organization access to my forks of kubernetes/examples and kubernetes/contributor-playground.
The reason I started this was because I found an error in Minikube Dashboard about the guestbook pods. The error occurs when Docker attempts to pull
registry.k8s.io/guestbook:v3
which is using an outdated image format or manifest version. I am hoping that resolving the build issues will also result in an updated image in the public repo that will enable everyone to run guestbook-go pods on up-to-date environments but the image needed an update either way and this is something I can help with.Here's the error on Docker Pull that shows up in Minikube Dashboard: