-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: upgrade etcd to 3.4.13-3 #100612
Conversation
i don't know why there is a -3 revision and what is included in that. we tend to update the GCE/kube-up tests and kubeadm at the same time. usually by the time we move to a -X revisions there is a new etcd MINOR / PATCH version we can move to instead: maybe this is what we want instead. there is also: /hold |
/sig api-machinery |
It seems no special changes. |
For kubernetes 1.22 release, etcd 3.5.x may be a better choice. |
@pacoxu can you please change the GCE scripts to -3 too? cc @jpbetz @wenjiaswe @dims do these revisions contain security fixes that are needed for 1.21? should we instead move to a new etcd PATCH or MINOR version? |
we should stay as close to what we use in go.mod file: So the |
/assign @wenjiaswe @jingyih |
/cc @ptabor |
@wenjiaswe: GitHub didn't allow me to request PR reviews from the following users: ptabor. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All the For consistency, let's also update the revision suffix used in tests and GCE scripts. For reference: #94287 |
Rebased. Per #100612 (comment) Currently, 3.4.13-3 would be a better option. |
/lgtm |
|
Signed-off-by: pacoxu <[email protected]>
rebase fixed. /assign @wojtek-t |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
kubernetes/cluster/images/etcd/Makefile
Lines 32 to 37 in f4801a7
Why we still use 3.4.13-0 here? Is there a special reason?
Which issue(s) this PR fixes:
xref #45506
During investigation etcd versions matrix, I find the revision here is still 3.4.13-0.
Special notes for your reviewer:
Does this PR introduce a user-facing change?