Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conversion-gen: check for nil pkg in getManualConversionFunctions #55948

Merged
merged 1 commit into from
Nov 18, 2017
Merged

conversion-gen: check for nil pkg in getManualConversionFunctions #55948

merged 1 commit into from
Nov 18, 2017

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Nov 17, 2017 •
edited
Loading

What this PR does / why we need it:

Following #54394, this PR performs a check in getManualConversionFunctions for packages that are not found and prints a warning instead of panicking.

This should improve the UX of conversion-gen, and is also a narrower change than that proposed in #54394, so hopefully can be cherry picked into the release-1.8 etc. branches.

This would allow users to use conversion-gen via the generate-internal-groups.sh script without having to make a second call that 'blanks out' --extra-peer-dirs.

/cc @sttts

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2017
@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, wojtek-t

Associated issue: 54394

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55841, 55948, 55945). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a83f78e into kubernetes:master Nov 18, 2017
@munnerz munnerz mentioned this pull request Nov 20, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 21, 2017
Merge pull request #56073 from munnerz/automated-cherry-pick-of-#5594…
2b57364 
…8-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55948

Cherry pick of #55948 on release-1.8.

#55948: conversion-gen: check for nil pkg in

```release-note
Fix issue preventing generation of conversions via generate-internal-groups.sh script
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@munnerz @wojtek-t @k8s-github-robot @sttts @k8s-ci-robot