Merge nvidia-gpu-device-plugin and nvidia-device-plugin.

[RamBITS-AI]

Fixes #19114.

EDIT:
Merged both the addons, nvidia-gpu-device-plugin and nvidia-device-plugin, into nvidia-device-plugin addon.

BEFORE:

minikube start --driver docker --container-runtime docker --gpus all

minikube status
minikube kubectl -- get pods -A

minikube addons enable nvidia-device-plugin --alsologtostderr

minikube addons enable nvidia-gpu-device-plugin --alsologtostderr

AFTER:

minikube start --driver docker --container-runtime docker --gpus all

minikube status
minikube kubectl -- get pods -A

minikube addons enable nvidia-device-plugin --alsologtostderr

minikube addons enable nvidia-gpu-device-plugin --alsologtostderr

[k8s-ci-robot]

Hi @RamBITS-AI. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RamBITS-AI
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spowelljr]

Hi @RamBITS-AI, thanks for the PR! There might have been a miscommunication but nvidia-device-plugin is the addon we want users to be using as it's being kept up to date, nvidia-gpu-device-plugin on the other hand hasn't been updated in 2.5 years, to that's the one we want to deprecate and move users off of.

[RamBITS-AI]

Yes, will do @spowelljr.

[spowelljr]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19545) |
+----------------+----------+---------------------+
| minikube start | 50.1s    | 51.8s               |
| enable ingress | 15.2s    | 15.9s               |
+----------------+----------+---------------------+

Times for minikube start: 47.5s 50.0s 48.3s 54.2s 50.4s
Times for minikube (PR 19545) start: 50.8s 51.4s 52.5s 54.3s 50.0s

Times for minikube ingress: 16.5s 15.5s 15.0s 14.5s 14.5s
Times for minikube (PR 19545) ingress: 15.5s 15.5s 17.1s 16.1s 15.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19545) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.2s               |
| enable ingress | 11.6s    | 12.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 21.3s 24.0s 21.0s 20.7s
Times for minikube (PR 19545) start: 20.9s 20.4s 24.0s 23.4s 22.5s

Times for minikube ingress: 12.7s 10.3s 10.8s 12.3s 11.8s
Times for minikube (PR 19545) ingress: 12.3s 12.7s 12.8s 12.8s 10.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19545) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 21.2s               |
| enable ingress | 23.0s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.7s 22.8s 23.2s 22.8s 23.2s
Times for minikube (PR 19545) ingress: 23.2s 23.3s 23.3s 22.7s 23.2s

Times for minikube start: 19.3s 22.0s 18.7s 22.5s 22.8s
Times for minikube (PR 19545) start: 21.8s 19.1s 19.8s 22.7s 22.3s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux_crio (4 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
Docker_Linux_crio (4 failed)	TestFunctional/parallel/ImageCommands/ImageLoadDaemon(gopogh)	11.43% (chart)
none_Linux (1 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
Docker_Linux (1 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
Docker_Linux_crio_arm64 (3 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
Docker_Cloud_Shell (4 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
Docker_macOS (1 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
Docker_Linux_docker_arm64 (1 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown
KVM_Linux (1 failed)	TestAddons/serial/GCPAuth/PullSecret(gopogh)	Unknown

Besides the following environments also have failed tests:

• Hyperkit_macOS: 20 failed (gopogh)

• QEMU_macOS: 157 failed (gopogh)

• Hyper-V_Windows: 22 failed (gopogh)

• KVM_Linux_crio: 33 failed (gopogh)

• Docker_Linux_containerd_arm64: 2 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[RamBITS-AI]

Hi @spowelljr,

Have updated the AFTER screenshots for the requested change.

[spowelljr]

Curious where you got these YAML changes from

[RamBITS-AI]

From here, @spowelljr :

minikube/deploy/addons/gpu/nvidia-gpu-device-plugin.yaml.tmpl

Lines 35 to 38 in a0f915e

	- operator: "Exists"
	effect: "NoExecute"
	- operator: "Exists"
	effect: "NoSchedule"