Allow turning off the VBox accelerate3d flag

[afbjorklund]

Oracle VirtualBox version 7.1 seems to have some issues with
the --accelerate3d that was used by default with VirtualBox.

minikube start --driver=virtualbox --no-accelerate3d-off

Closes #19639

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afbjorklund]

But minikube started just fine (on Linux) without this fix, as well.

When using 7.1.2 from https://www.virtualbox.org/wiki/Downloads

So it might not be needed with all graphics card and on all distros.

Just with some, so make it an option (like --no-vtx-check for cpuid)

[afbjorklund]

Added PR for the failing functional_podman_ubuntu test in CI:

• Add missing quotes around podman_ubuntu e2e test #19731

[spowelljr]

I completely agree with the idea of the PR, the flag being a double negative is a little confusing though, could we just rename it to accelerate3d?

ie. --accelerate3d=true vs --no-accelerate3d-off=true

[afbjorklund]

I completely agree with the idea of the PR, the flag being a double negative is a little confusing though, could we just rename it to accelerate3d?

ie. --accelerate3d=true vs --no-accelerate3d-off=true

Sure, but that is not what the flag does. It removes the parameter --accelerate3d=off from VBoxManage modifyvm.

Because in some builds, that flag is now throwing an error... But the 3D acceleration was never meant to be enabled.

[spowelljr]

I see, if the accelerate3d flag is not specified what does it default to? If it defaults to false we could just remove it for everyone, but I'm assuming that's not the case.