-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EndpointSlice 1.22 Docs Update (KEP 752) #28745
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 1168b46 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61005c5b66a0a6000809b8ec |
thank you for opening this, please remember to hold until the enhancement is no longer labelled 'At Risk'. /sig network |
kubernetes/kubernetes#103596 suggests this PR might also need to cover |
The enhancement is no longer at risk. All relevant PRs were merged yesterday. This PR is to cover the changes related to kubernetes/enhancements#752 kubernetes/kubernetes#103596 is for a different KEP. I believe |
Hello @swetharepakula 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 20th of July, 11:59 PM PDT. In comments, you mentioned it is WIP, hence sending reminder. Thank you! |
Hi @swetharepakula friendly reminder that today is the deadline for PRs ready for review, please make sure this PR is ready for review by the end of the day, thank you! |
Thanks for the reminder @ritpanjw & @PI-Victor! The PR is now ready for review |
LGTM |
Thanks for the quick response @sftim! That approach makes sense to me. I think the docs for 1.21 are already sufficient here. |
cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: warning`. | ||
This annotation indicates that the affected Endpoints object is over capacity. | ||
If an Endpoints resource has more than 1000 endpoints then a Kubernetes v1.22 (or later) | ||
cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: truncated`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can you be more specific? What annotates the Endpoints resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small addition stating that the endpoint controller truncates the resource. Please let me know if you think we should expand more. I am not sure how detailed I should be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“the control plane has truncated” would be fine.
@@ -188,9 +188,10 @@ selectors and uses DNS names instead. For more information, see the | |||
[ExternalName](#externalname) section later in this document. | |||
|
|||
### Over Capacity Endpoints | |||
If an Endpoints resource has more than 1000 endpoints then a Kubernetes v1.21 (or later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maybe edit the v1.21 docs (either now or post release) to remove the “or later” part from the v1.21 docs. WDYT @swetharepakula ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that is a good point! I can send in a followup pr for that. Which branch would that pr need to be against?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, that is the main branch: commits there are continuously published to https://kubernetes.io/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR to update existing 1.21 docs: #29122
Next step is a tech review from SIG Network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: warning`. | ||
This annotation indicates that the affected Endpoints object is over capacity. | ||
If an Endpoints resource has more than 1000 endpoints then a Kubernetes v1.22 (or later) | ||
cluster annotates that Endpoints with `endpoints.kubernetes.io/over-capacity: truncated`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“the control plane has truncated” would be fine.
LGTM label has been added. Git tree hash: 6bccddd1d29f71c3b65153eb6bf13c04253d06e3
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@swetharepakula can you please rebase, a fix to the feature gates table was merged and caused this to conflict. |
* Graduate proxying gates * Endpoints Controller truncates endpoints to 1000 and sets over-capacity annotation to `truncated`
PR has been rebased. Is there anything left for this PR? Or do we still need the hold? |
a tech LGTM from @kubernetes/sig-network-pr-reviews is all that is needed, when this is done we can remove the hold. |
We have the tech review I think: #28745 (comment) |
/lgtm |
LGTM label has been added. Git tree hash: b344b66b4a425a01e768b284bef3ff202c42039a
|
This PR includes the doc updates required since EndpointSlice is going GA in 1.22.