Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog about pod scheduling readiness #37436

Merged

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Oct 21, 2022

Placeholder PR for the blog "Pod Scheduling Readiness".

/sig scheduling

KEP: kubernetes/enhancements#3521

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2022
@netlify
Copy link

netlify bot commented Oct 21, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8bc5439
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/638d59b61a45e50008397a71
😎 Deploy Preview https://deploy-preview-37436--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Oct 22, 2022

/retitle [WIP] Add blog article about pod scheduling readiness

@k8s-ci-robot k8s-ci-robot changed the title Placeholder for blog pod scheduling readiness [WIP] Add blog article about pod scheduling readiness Oct 22, 2022
@bradmccoydev
Copy link
Member

Hello @Huang-Wei! v1.26 Comms shadow here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help! cc @fsmunoz

@Huang-Wei
Copy link
Member Author

@bradmccoydev thanks for the reminder. I will have some cycles early next week, and it's quite optimistic to finish the draft before the deadline.

@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 29, 2022

Hello @Huang-Wei , today is Review Readiness deadline, it's important not to miss it since it can imply dropping the feature blog :( If we can be of any help, we'e here!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2022
@Huang-Wei Huang-Wei changed the title [WIP] Add blog article about pod scheduling readiness Blog about pod scheduling readiness Nov 29, 2022
@Huang-Wei Huang-Wei marked this pull request as ready for review November 29, 2022 19:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@Huang-Wei
Copy link
Member Author

@fsmunoz it's ready for review now.

(cc @ahg-g )

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

If feasible, use SVG images - see the diagram guide for our docs guidelines, which mostly also apply to blog articles.

https://www.k8s.dev/blog/2021/12/01/improve-your-documentation-with-mermaid.js-diagrams/ has some more tips.

@sftim
Copy link
Contributor

sftim commented Nov 29, 2022

/hold

Ready for release comms to assign a publication date

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2022
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@Huang-Wei Huang-Wei force-pushed the blog-pod-scheduling-readiness branch from 9f40755 to 2cc6e82 Compare December 1, 2022 23:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@Huang-Wei
Copy link
Member Author

@sftim Mermaid bits updated. Although I tried pretty hard to make it close to my original pictures, it's somehow restricted on how different parts are positioned, and how the arrows get rendered. So take a look and let me know if it's good enough.

@sftim
Copy link
Contributor

sftim commented Dec 2, 2022

For the diagrams, if you want to, you can save to SVG and load that up into an editor such as Inkscape, then make any tweak you see as reasonable.

Please convert text to curves before saving (it's also handy to save a copy of the Mermaid source somewhere)/

@Huang-Wei
Copy link
Member Author

For the diagrams, if you want to, you can save to SVG and load that up into an editor such as Inkscape, then make any tweak you see as reasonable.

I prefer to use Mermaid texts only and thus it's editable in the future. For embedding a tweaked SVG, it's still not convenient to modify in the future.

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 3, 2022

Hello, Comms Lead for v1.26 here. The publication order and date for the Feature Blog series has been finalised and the tracking board updated (cf. discussion).

The publication date for this article is 26-12-2022 (December 26).

Thanks!

@Huang-Wei
Copy link
Member Author

@fsmunoz thanks, the document was renamed to carry 2022-12-26 in its path.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback

@Huang-Wei Huang-Wei force-pushed the blog-pod-scheduling-readiness branch from 3c09276 to 8bc5439 Compare December 5, 2022 02:38
@sftim
Copy link
Contributor

sftim commented Dec 5, 2022

I prefer to use Mermaid texts only and thus it's editable in the future. For embedding a tweaked SVG, it's still not convenient to modify in the future.

For a blog article, it's even better to embed an SVG with text converted to curves, and place a link to edit the Mermaid.
https://kubernetes.io/docs/contribute/style/diagram-guide/#mermaid-svg explains this approach.

This is a bit more work for someone who wants to edit the blog article, but also less maintenance for the site overall, so the Mermaid+SVG approach approach scales better (we will have more changes that are not to this article than we will have changes that do touch this article).

We can merge with the Mermaid image and convert later, so that doesn't block progress here.

@sftim
Copy link
Contributor

sftim commented Dec 6, 2022

/lgtm
/approve

/hold
OK to unhold once Kubernetes 1.26 is released.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4cf1e97c9631abbf7f8b696cc2a10713527807cb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 7, 2022

Marking this Ready for Publishing in Comms tracking, thank you for all the work - minor edits/reviews are still doable until the release date.

/lgtm

@Huang-Wei
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4c88c80 into kubernetes:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

6 participants