-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document labels, annotations and taints for JobSet #47383
base: main
Are you sure you want to change the base?
Document labels, annotations and taints for JobSet #47383
Conversation
Hi @sftim ,could you review on these changes if anythings need to change let me know . |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
This label provides a unique key for the job. | ||
|
||
### job-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already defined as part of the job api labels/annotations.
### job-name | ||
|
||
Type: Label | ||
|
||
Example: `job-name: "my-job"` | ||
|
||
Used on: Jobs | ||
|
||
This label stores the name of the job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### job-name | |
Type: Label | |
Example: `job-name: "my-job"` | |
Used on: Jobs | |
This label stores the name of the job. |
This is not in the namespace kubernetes.io
or k8s.io
, so we'd omit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed it in case any need to change let me know.
|
||
Used on: Jobs, Pods | ||
|
||
This label is used to store the name of the JobSet to which a job or pod belongs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label is used to store the name of the JobSet to which a job or pod belongs. | |
This label is used to store the name of the JobSet to which a Job or Pod belongs. | |
JobSet is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this change as suggested.
|
||
Used on: Jobs | ||
|
||
This label is used to index into a job's labels and retrieve the name of the parent ReplicatedJob. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label is used to index into a job's labels and retrieve the name of the parent ReplicatedJob. | |
This label is used to index into a Job's labels and retrieve the name of the parent ReplicatedJob. | |
ReplicatedJob is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this change as suggested
|
||
Used on: Jobs | ||
|
||
This annotation stores the index of the job within the ReplicatedJob. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation stores the index of the job within the ReplicatedJob. | |
This annotation stores the index of the Job within the ReplicatedJob. | |
ReplicatedJob is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this change as suggested
|
||
Used on: JobSets, ReplicatedJobs | ||
|
||
This annotation can be set on a JobSet or a ReplicatedJob template to ensure exclusive job placement per topology group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation can be set on a JobSet or a ReplicatedJob template to ensure exclusive job placement per topology group. | |
You can set this annotation on a JobSet or a ReplicatedJob template to ensure exclusive job placement per topology group. | |
JobSet and ReplicaSet are extension APIs that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this change as suggested.
|
||
Used on: JobSets | ||
|
||
This annotation acts as a flag. When set, the JobSet controller injects nodeSelectors for the JobSetNameKey label to ensure exclusive job placement per topology. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a JobSetNameKey?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JobSetNameKey is the label key that identifies the JobSet to which a job belongs. Specifically, it is the label jobset.sigs.k8s.io/jobset-name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have update this if need to improvement let me know.
### alpha.jobset.sigs.k8s.io/no-schedule | ||
|
||
Type: Annotation | ||
|
||
Example: `alpha.jobset.sigs.k8s.io/no-schedule: "true"` | ||
|
||
Used on: Jobs | ||
|
||
This annotation prevents the job from being scheduled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is right. You can suspend a Job or set scheduling gates on a Pod, but I don't see how or whether this annotation influences those things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used as a taint for the node labeling exclusive placement strategy (link)
|
||
Used on: Jobs, Pods | ||
|
||
This annotation/label is used on Jobs and Pods to store a stable network endpoint where the coordinator pod can be reached if the JobSet spec defines the `.spec.coordinator` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation/label is used on Jobs and Pods to store a stable network endpoint where the coordinator pod can be reached if the JobSet spec defines the `.spec.coordinator` field. | |
This annotation/label is used on Jobs and Pods to store a stable network endpoint where the coordinator | |
pod can be reached if the JobSet spec defines the `.spec.coordinator` field. | |
JobSet is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this change as suggested.
### jobset.sigs.k8s.io/jobset-controller | ||
|
||
Type: Label | ||
|
||
Example: `jobset.sigs.k8s.io/jobset-controller: "jobset-controller"` | ||
|
||
Used on: Jobs | ||
|
||
This label is used for the `managedBy` field to indicate that the job is managed by the built-in JobSet controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### jobset.sigs.k8s.io/jobset-controller | |
Type: Label | |
Example: `jobset.sigs.k8s.io/jobset-controller: "jobset-controller"` | |
Used on: Jobs | |
This label is used for the `managedBy` field to indicate that the job is managed by the built-in JobSet controller. |
This is not a label, it's a value for managedBy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tim is correct, we can remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have remove this change as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @kannon92, I added a couple comments
### jobset.sigs.k8s.io/jobset-controller | ||
|
||
Type: Label | ||
|
||
Example: `jobset.sigs.k8s.io/jobset-controller: "jobset-controller"` | ||
|
||
Used on: Jobs | ||
|
||
This label is used for the `managedBy` field to indicate that the job is managed by the built-in JobSet controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tim is correct, we can remove this.
### alpha.jobset.sigs.k8s.io/no-schedule | ||
|
||
Type: Annotation | ||
|
||
Example: `alpha.jobset.sigs.k8s.io/no-schedule: "true"` | ||
|
||
Used on: Jobs | ||
|
||
This annotation prevents the job from being scheduled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used as a taint for the node labeling exclusive placement strategy (link)
@Adarsh-verma-14 is the one who worked on this. |
Type: Annotation | ||
|
||
Example: `alpha.jobset.sigs.k8s.io/no-schedule: "true"` | ||
|
||
Used on: Jobs | ||
|
||
This annotation prevents the job from being scheduled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type: Annotation | |
Example: `alpha.jobset.sigs.k8s.io/no-schedule: "true"` | |
Used on: Jobs | |
This annotation prevents the job from being scheduled. | |
Type: Taint | |
Example: `alpha.jobset.sigs.k8s.io/no-schedule: NoSchedule` | |
Used on: Nodes | |
The JobSet controller uses this taint to support its node labeling exclusive placement strategy. | |
JobSet is an extension API that you can deploy into your Kubernetes cluster. |
(aside: I'd rename this to jobset.sigs.k8s.io/exclusive-use
or jobset.kubernetes.io/exclusive-use
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this changes but is there need to change name (jobset.sigs.k8s.io/exclusive-use or jobset.kubernetes.io/exclusive-use) let me know.
There is also one taint, so: /retitle Document labels, annotations and taints for JobSet |
/sig apps |
Woops, sorry about that @Adarsh-verma-14! Thanks for the contribution :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nearly LGTM for docs
|
||
Used on: JobSets | ||
|
||
This annotation acts as a flag. When set, the JobSet controller injects nodeSelectors for the `JobSetNameKey` label (e.g., `jobset.sigs.k8s.io/jobset-name`) to ensure exclusive job placement per topology. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could tidy the explanation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation acts as a flag. When it's set, the JobSet controller adds nodeSelectors for the JobSetNameKey
label (like jobset.sigs.k8s.io/jobset-name
), so jobs are placed according to a specific topology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim it would be better or not ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the JobSet controller mutate based on this annotation?
- JobSets
- Jobs
- Pods
?
It's not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it your point @sftim , I will update this accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have update this accordingly. Now, i think is clear. PTAL!!
@sftim any blockers here? Scanning through it looks like comments have been addressed |
This PR is ready for a review (any reviewer for English). |
Thanks! Would you mind tagging a reviewer for this? I'm not sure who to add. |
#47383 (comment) shows the suggested reviewers. I'll take a look if I get time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; this needs more work though. For example, there's no such thing as a cluster-scoped Job.
Ideally, get a tech review from SIG Apps after making the next set up updates.
|
||
Used on: JobSets | ||
|
||
This annotation acts as a flag. When set, the JobSet controller injects nodeSelectors for the `JobSetNameKey` label (e.g., `jobset.sigs.k8s.io/jobset-name`) to ensure exclusive job placement per topology. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the JobSet controller mutate based on this annotation?
- JobSets
- Jobs
- Pods
?
It's not clear.
|
||
Used on: Jobs | ||
|
||
This annotation indicates that the job is namespaced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any Jobs not namespaced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annoation is actually used to store the namespaced Job name - @Adarsh-verma-14 can you fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I will fix it @danielvegamyhre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed it cloud you check it is fine now ?
Waiting on author updates and then on tech LGTM. |
|
||
Type: Annotation, Label | ||
|
||
Example: `jobset.sigs.k8s.io/coordinator: "coordinator-endpoint"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example: `jobset.sigs.k8s.io/coordinator: "coordinator-endpoint"` | |
Example: `jobset.sigs.k8s.io/coordinator: "myjobset-workers-0-0.headless-svc"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will replace with endpoint.
|
||
Example: `alpha.jobset.sigs.k8s.io/node-selector-strategy=true` | ||
|
||
Used on: JObs ,Pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used on: JObs ,Pods | |
Used on: Jobs ,Pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uff my bad!! i will fix it.
Used on: Nodes | ||
|
||
The JobSet controller uses this taint to support its node labeling exclusive placement strategy. | ||
JobSet is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice here you mention "JobSet is an extension API that you can deploy into your Kubernetes cluster" but not in any other taint/label/annotation descriptions.
I think it would make more sense to delete this and instead make the word "JobSet" a link to https:/kubernetes-sigs/jobset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure i will add link for Jobset
|
||
Type: Annotation, Label | ||
|
||
Example: `alpha.jobset.sigs.k8s.io/namespaced-job:my-jobset-replicatedjob-A-0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example: `alpha.jobset.sigs.k8s.io/namespaced-job:my-jobset-replicatedjob-A-0` | |
Example: `alpha.jobset.sigs.k8s.io/default_myjobset-replicatedjob-0` |
see https:/kubernetes-sigs/jobset/blob/main/pkg/controllers/jobset_controller.go#L804
Also, the format of child job names for JobSets is: {jobset}-{replicatedJob}-{jobIndex}
Used on: JobSets, ReplicatedJobs | ||
|
||
You can set this annotation on a JobSet or a ReplicatedJob template to ensure exclusive job placement per topology group. | ||
JobSet and ReplicaSet are extension APIs that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this sentence and make the word JobSet
a link to the jobset repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
This annotation stores the index of the Job within the ReplicatedJob. | ||
ReplicatedJob is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This annotation stores the index of the Job within the ReplicatedJob. | |
ReplicatedJob is an extension API that you can deploy into your Kubernetes cluster. | |
This label/annotation is set by the JobSet controller on child Jobs and Pods. It contains the index of the Job replica within its parent ReplicatedJob. |
|
||
### jobset.sigs.k8s.io/job-key | ||
|
||
Type: Label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also used as annotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will register this as annotation also
@@ -2332,6 +2332,114 @@ Starting in v1.16, this annotation was removed in favor of | |||
[Pod Priority](/docs/concepts/scheduling-eviction/pod-priority-preemption/). | |||
{{< /note >}} | |||
|
|||
### jobset.sigs.k8s.io/jobset-name | |||
|
|||
Type: Label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these are used as both labels and annotations (except the taint).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will register for both labels and annotation
Used on: ReplicatedJobs | ||
|
||
This annotation specifies the number of replicas for a ReplicatedJob. | ||
ReplicatedJob is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this sentence, it is not accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i will remove it
Used on: Jobs, Pods | ||
|
||
This label is used to store the name of the JobSet to which a Job or Pod belongs. | ||
JobSet is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the word "JobSet" a link to the JobSet github repo for readers who are unfamiliar with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure I will link that.
Thanks @Adarsh-verma-14, please tag me when this is ready for another review |
Sure |
Hi @danielvegamyhre , I have updated changes as suggested now you can review on it . |
Used on: Jobs, Pods | ||
|
||
This label/annotation is used to index into a Job's labels and retrieve the name of the parent ReplicatedJob. | ||
ReplicatedJob is an extension API that you can deploy into your Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this sentence please, ReplicatedJob is not an extension API that can be installed on your cluster, that is JobSet :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh sorry, i missed it !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed it. PTAL!!
|
||
Example: `alpha.jobset.sigs.k8s.io/node-selector-strategy=true` | ||
|
||
Used on: Jobs ,Pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used on: Jobs ,Pods | |
Used on: Jobs, Pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated it also PTAL!!
Sorry, I'm against this change because
|
Thanks for the comment @tengqm, but JobSet is part of the Kubernetes project. I don't think we should force SIG Apps to reorganize a long page just to register their labels and annotations, even if that work is a good idea for the long term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple more small changes
|
||
Used on: Jobs, Pods | ||
|
||
This label/annotation is used to store the name of the JobSet to which a Job or Pod belongs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label/annotation is used to store the name of the JobSet to which a Job or Pod belongs. | |
This label/annotation is used to store the name of the JobSet that a Job or Pod belongs to. |
|
||
Used on: Jobs, Pods | ||
|
||
This label/annotation is used to index into a Job's labels and retrieve the name of the parent ReplicatedJob. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label/annotation is used to index into a Job's labels and retrieve the name of the parent ReplicatedJob. | |
This label/annotation stores the name of the ReplicatedJob that this Job or Pod is part of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will update this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. PTAL !!
/lgtm for JobSet @sftim this is ready for SIG docs review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no API kind called ReplicatedJob, right?
If that's true, try these changes. We main use the UpperCamelCase notation for actual API kinds.
/lgtm cancel
|
||
Used on: Jobs, Pods | ||
|
||
This label/annotation stores the name of the ReplicatedJob that this Job or Pod is part of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label/annotation stores the name of the ReplicatedJob that this Job or Pod is part of. | |
This label or annotation stores the name of the replicated job that this Job or Pod is part of. |
|
||
Used on: Jobs, Pods | ||
|
||
This label/annotation is set by the JobSet controller on child Jobs and Pods of a JobSet. The value will be the SHA256 hash of the namespaced Job name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label/annotation is set by the JobSet controller on child Jobs and Pods of a JobSet. The value will be the SHA256 hash of the namespaced Job name. | |
The JobSet controller sets this label (and also an annotation with the same key) on child Jobs and | |
Pods of a JobSet. The value is the SHA256 hash of the namespaced Job name. |
|
||
Used on: JobSets, ReplicatedJobs | ||
|
||
You can set this label/annotation on a [JobSet](https://jobset.sigs.k8s.io) or a ReplicatedJob template to ensure exclusive job placement per topology group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set this label/annotation on a [JobSet](https://jobset.sigs.k8s.io) or a ReplicatedJob template to ensure exclusive job placement per topology group. | |
You can set this label/annotation on a [JobSet](https://jobset.sigs.k8s.io) to ensure exclusive Job | |
placement per topology group. You can also define this label or annotation on a replicated job | |
template. Read the documentation for JobSet to learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this soon
@Adarsh-verma-14 can you address sftim@'s comments as soon as you can please? The JobSet blog post PR is blocked by this one, so we are hoping to get it merged as soon as possible :) |
sure |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi , I have updated these changes as suggested by @sftim . PTAL!! |
Adding labels and annotation for JobSet in https:/kubernetes/website/blob/main/content/en/docs/reference/labels-annotations-taints/_index.md
Fixes #47373
/language en