Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41589: Error "Cannot read properties of undefined (reading "push")" on creation of a VM with Sysprep #1980

Merged
merged 1 commit into from
May 27, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented May 27, 2024

📝 Description

Since a VM in IT flow is created without disks, this error occurs

🎥 Demo

Before:

push-undefined.mp4

After:

push-undefined-after.mp4

…)" on creation of a VM with Sysprep

Signed-off-by: Aviv Turgeman <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 27, 2024

@avivtur: This pull request references CNV-41589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Since a VM in IT flow is created without disks, this error occurs

🎥 Demo

Before:

push-undefined.mp4

After:

push-undefined-after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and upalatucci May 27, 2024 12:48
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 27, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1378c92 into kubevirt-ui:main May 27, 2024
10 checks passed
@gouyang
Copy link
Member

gouyang commented Jun 5, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #2010

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants