Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-48785: Fix disk size #2193

Merged

Conversation

metalice
Copy link
Member

📝 Description

Disk size didn't worked for long time, since DV name isn't ROODISK in default, that will fix it.

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 22, 2024

@metalice: This pull request references CNV-48785 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

Disk size didn't worked for long time, since DV name isn't ROODISK in default, that will fix it.

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 22, 2024
@metalice metalice force-pushed the CNV-48785-fix-disk-size-changes branch 3 times, most recently from 629fb90 to e8fe6d6 Compare September 22, 2024 06:15
Signed-off-by: Matan Schatzman <[email protected]>
@metalice metalice force-pushed the CNV-48785-fix-disk-size-changes branch from e8fe6d6 to 190b167 Compare September 22, 2024 06:24
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 22, 2024
Copy link
Contributor

openshift-ci bot commented Sep 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 15944b1 into kubevirt-ui:main Sep 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants