More permissive check for page allocation mmap #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed intermittent page allocation failures when attempting to apply a patch. This has occurred on OSX in an environment that I believe to be under significant memory pressure, although it is difficult to reproduce.
It seems like the check for pages returned by
mmap
might be too strict. This PR attempts to make the check more permissive while still being safe for 32-bit relative jumps.