Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Design についてREADMEにまとめる #377

Open
kobakazu0429 opened this issue Jul 9, 2019 · 2 comments
Open

Atomic Design についてREADMEにまとめる #377

kobakazu0429 opened this issue Jul 9, 2019 · 2 comments

Comments

@kobakazu0429
Copy link
Member

No description provided.

@kobakazu0429
Copy link
Member Author

@kure-kosen/cho_kure_design_renewal
本当にAtomic Designでいいのか、という問題があるので議論したいです
個人的には失敗だと思ってます…

@kobakazu0429
Copy link
Member Author

現状

src
├── components
      ├── App
      │   └── index.tsx
      ├── atoms
      │   ├── AboutBottom
      │   ├── Blog
      │   ├── Buttons
      │   ├── FeaturedPersonality
      │   ├── Features
      │   ├── Forms
      │   ├── HeroArea
      │   ├── PopularRadio
      │   ├── RadioCard
      │   ├── RadioHistory
      │   ├── RadioSearcher
      │   ├── Slider
      │   ├── Spinners
      │   └── WeeklyComic
      └── molecules
          ├── Blogs
          ├── Contact
          ├── HeroArea
          ├── Personalities
          ├── PopularRadio
          ├── RadioCard
          ├── RadioHistory
          ├── RadioPersonalityIcons.tsx
          └── RadioSearcher
省略

改善案

src
├── components
      ├── App
      ├── common // 共通のコンポーネント
      │  ├── Buttons
      │  ├── Features
      │  ├── Forms
      │  ├── Slider
      │  └── Spinners
      │ // ↓commonや他のコンポーネントを使って作る
      ├── AboutBottom
      ├── Blog
      ├── Contact
      ├── HeroArea
      ├── Personality
      ├── PopularRadio
      ├── RadioCard
      ├── RadioHistory
      ├── RadioPersonalityIcons.tsx
      ├── RadioSearcher
      └── WeeklyComic
省略

割と普通だけどこれが無難な気がしてきた

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant