Radio History Pageの作成 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euglena1215
reviewed
Jun 23, 2018
frontend/webpack.config.js
Outdated
| @@ -0,0 +1,50 @@ | |||
| const path = require("path"); | |||
There was a problem hiding this comment.
[ESLint]
Error - 構文解析エラー: 'const' は予約語です。
|
@kobakazu0429 |
|
@euglena1215 @chanyou0311 |
|
サイドバーとコンテンツの幅が微妙な気がする... |
euglena1215
reviewed
Jun 26, 2018
| @@ -1,11 +1,13 @@ | |||
| import * as React from "react"; | |||
| import styled from "styled-components"; | |||
|
|
|||
| export const RadioCardWrapper = () => <RadioCardWrapperStyle>radio-card-wrapper</RadioCardWrapperStyle>; | |||
| const card = "http://localhost:5000/images/radio-card.png"; | |||
There was a problem hiding this comment.
📝 このままだとproductionに載せられないのでいい感じに変更する
euglena1215
reviewed
Jul 4, 2018
| @@ -1,3 +1,7 @@ | |||
| export const chkColors = { | |||
| orange: "#edb600", | |||
| blue: "#8bc8d9", | |||
| gray: "#7f8287", | |||
| shadow: "#14141433", | |||
euglena1215
reviewed
Jul 4, 2018
| import * as React from "react"; | ||
| import styled from "styled-components"; | ||
|
|
||
| const feature = "http://localhost:5000/images/radio-history-feature.jpg"; |
|
サンクス！マージしちゃいましょう |
euglena1215
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #301
WHY
WHAT
やったこと
Search
About
#298 をやってしまった...RadioHistoryFeature
font-weight: normalfont-weight: boldやってないこと
./frontend/src/commons/color.tsに追加したいPopularRadios #287
Radio #288
TweetStream #289
RadioCard #291
FeaturedBlogWrapper #296