Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide when to upgrade testing dev dependency tox to v4 #313

Closed
viniarck opened this issue Dec 8, 2022 · 1 comment · Fixed by #460
Closed

Decide when to upgrade testing dev dependency tox to v4 #313

viniarck opened this issue Dec 8, 2022 · 1 comment · Fixed by #460

Comments

@viniarck
Copy link
Member

viniarck commented Dec 8, 2022

tox v4 has just been released with breaking changes. This issue is for deciding, and assessing later on when we should consider switching. This might impact adapting tox ini files as well on core projects and NApps.

See kytos-ng/of_core#93 for more information.
@viniarck viniarck added the future_release Planned for the next release label Dec 8, 2022
This was referenced Dec 8, 2022
Closed
Closed
italovalcy added a commit to kytos-ng/mef_eline that referenced this issue Jan 18, 2023
@italovalcy
pinned tox version (Issue kytos-ng/kytos#313)
b753813 
Issue kytos-ng/of_core#94: pinned tox version while kytos-ng/kytos#313 gets fixed
@italovalcy italovalcy mentioned this issue Jan 18, 2023
Merged
italovalcy added a commit to kytos-ng/mef_eline that referenced this issue Jan 18, 2023
@italovalcy
Merge pull request #237 from kytos-ng/italovalcy-patch-1
18c462c 
pinned tox version due to Issue kytos-ng/kytos#313
@viniarck viniarck mentioned this issue Apr 12, 2023
Merged
@viniarck
Copy link
Member Author

viniarck commented Jan 8, 2024

There's also a new upgrade guide available https://tox.wiki/en/4.11.4/upgrading.html

Let's use this as a reference. The deps = -U flag is no longer supported, so only the -r should be maintained.

@viniarck viniarck mentioned this issue Jan 8, 2024
Merged
@viniarck viniarck mentioned this issue Feb 19, 2024
Closed
@viniarck viniarck removed the future_release Planned for the next release label Feb 27, 2024
@Alopalao Alopalao mentioned this issue Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Upgraded python and dependencies kytos-ng/kytos
1 participant
@viniarck