Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv==20.22.0 can cause wheels issue when tox try to install requirements/dev.txt #373

Closed
viniarck opened this issue Apr 20, 2023 · 1 comment
Assignees
Labels
2024.1 Kytos-ng 2024.1 epic_upgrade_py311 priority_medium Medium priority

Comments

@viniarck
Copy link
Member

viniarck commented Apr 20, 2023

@italovalcy has spotted this on GitLab CI unit tests nightly, I was looking into it, and just realized that virtualenv==20.22.0 has just been released, and it has broken some compatibilities, we do have virtualenv pinned on requirements/dev.txt, but both on Scrutinizer and GitLab CI we have pre pip commands that install tox version 3, so that leaves room for fetching virtualenv==20.22.0.

On Scrutinizer global config with pip install tox==3.27.1 virtualenv==20.21.0 coverage it's passing again, so the easiest route with less friction is to do the same on GitLab CI unit test pipelines for now. @italovalcy let me know if you could update the .gitlab-ci.yml files accordingly or if you need my help.

In the future, and even potentially on this version 2023.1, we could try to support virtualenv==20.22.0, and adapt setup.py just so wheels don't get triggered since NApps don't support them anyway (we do have a conditional on setup.py but we might need to do something else).

@viniarck viniarck added the priority_major Major priority label Apr 20, 2023
@viniarck viniarck self-assigned this Apr 20, 2023
@viniarck viniarck changed the title virtualenv==20.22.0 can cause wheels issue when tox try to install the requirements virtualenv==20.22.0 can cause wheels issue when tox try to install the requirements/dev.txt Apr 20, 2023
@viniarck viniarck changed the title virtualenv==20.22.0 can cause wheels issue when tox try to install the requirements/dev.txt virtualenv==20.22.0 can cause wheels issue when tox try to install requirements/dev.txt Apr 20, 2023
@viniarck viniarck added priority_medium Medium priority 2024.1 epic_upgrade_py311 2024.1 Kytos-ng 2024.1 and removed priority_major Major priority 2024.1 labels Feb 27, 2024
@viniarck
Copy link
Member Author

Landed on #460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024.1 Kytos-ng 2024.1 epic_upgrade_py311 priority_medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant