-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added in new blueprint for handling interruptions #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @Ktmi, great how this has evolved and emerged as interruptions.
Most of it looks good to me, asked minor implementation details clarifications though. Also, raised some questions that needs confirmation from network engineers to also confirm.
Another adjacent thing to consider, once a service has its primary path interrupted but then it eventually ends the interruption, is it expected that the service should be using its primary path if it's available again or it's OK to continue in a backup or failover path? Currently, |
This thread is still unanswered. |
I spoke with @italovalcy and the response is that for dynamic paths, when the original interruption that affected them ends, continue to use the recomputed path, unless the recomputed path was using flexible metrics and didn't satisfy all criteria. For static paths, we switch back to the original path. |
Cool. Please, later on map this requirement as an issue on mef_eline that's only desired circuits with static paths, that way one day it can be prioritized accordingly. |
@Ktmi there's also a conflict with |
@Ktmi, nicely done consolidating this blueprint, it's getting very close to land, I'm going to approve once these minor threads are closed/resolved:
Thanks, David. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done consolidating this blueprint @Ktmi.
If anything else on mef_eline
regarding provisioning paths during a maintenance is needed you can create a new issue, but since that won't impact much this blueprint, since the blueprint ended up very well agnostically solving the problem with interruptions, I'll go ahead and already leave it approved. If nobody has any extra comments or reviews we can merge this PR by Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have a few questions/comments that I discussed with David/Vinicius on slack (specially the need for SERVICE_PROVIDERS
setting versus using callback functions on top of existing events enhanced with a dry-run
parameter). However, overall, the blueprint is good to go!
Co-authored-by: Italo Valcy S Brito <[email protected]>
Let's ship it then. Congrats @Ktmi, and thanks @italovalcy for you feedback. If anything else minor is needed it'll be augmented in a next iteration. |
This is intended to resolve kytos-ng/maintenance#59. This provides a blueprint for a mechanism to handle interruptions such as maintenance windows.