DefaultHTTPErrorHandler: return error if marshalling JSON fails #2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when passing a message to echo.NewHTTPError() that is not serializable, no error is returned, but a 200 Ok response with no content.
I triggered this behavior by accident when using
err.Error
instead oferr.Error()
as message.I added test cases which trigger the problem for both
c.JSON()
as well asecho.NewHttpError()
. With the fix, both of them now return the same result (500 Internal Server Error).One thing open is to maybe close the whole connection if even the sending of the new error message fails.