Allow args after and between options

lahmatiy · Dec 12, 2021 · 21e2702 · 21e2702
1 parent 4152aef
commit 21e2702
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## next
+
+- Allowed args after and between options
+
 ## 3.0.0-beta.1
 
 - Restored wrongly removed `Command#extend()`

diff --git a/lib/parse-argv.js b/lib/parse-argv.js
@@ -131,8 +131,7 @@ module.exports = function parseArgv(command, argv, context, suggestMode) {
  };
  break;
  } else {
- if (rawOptions.length !== 0 ||
- context.args.length >= command.params.maxCount) {
+ if (context.args.length >= command.params.maxCount) {
  throw new CliError(`Unknown command: ${token}`);
  }
 

diff --git a/test/command-args-and-options.js b/test/command-args-and-options.js
@@ -83,6 +83,21 @@ describe('command run', function() {
  });
  });
 
+ it('args & options before', function() {
+ const actual = command.run(['--foo', '--bar', '123', 'qux']);
+
+ assert.deepStrictEqual(actual, {
+ commandPath: ['test'],
+ options: {
+ __proto__: null,
+ foo: true,
+ bar: 123
+ },
+ args: ['qux'],
+ literalArgs: null
+ });
+ });
+
  it('args & literal args', function() {
  const actual = command.run(['qux', '--', '--one', '--two', '123']);