Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft-deprecate this crate #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Soft-deprecate this crate #25

wants to merge 2 commits into from

Conversation

lambda-fairy
Copy link
Owner

No description provided.

@lambda-fairy
Copy link
Owner Author

lambda-fairy commented Apr 13, 2022 •
edited
Loading

Waiting on rust-lang/rust#53667

@smoelius
Copy link
Contributor

Waiting on rust-lang/rust#94927

Of course, rustfmt support for let_chains is not yet finalized: rust-lang/rustfmt#5203

One might continue to use this crate for that reason.

@est31
Copy link

est31 commented Apr 14, 2022

And macros do they have rustfmt support? rust-lang/rustfmt#8

I think MSRV is still a good reason to use this crate. Plus, of course there are tons of legacy users.

@lambda-fairy
Copy link
Owner Author

Ref: rust-lang/rust#94927

This will need to be updated to say Rust 1.64.

I think MSRV is still a good reason to use this crate. Plus, of course there are tons of legacy users.

Yes, that's why the proposed documentation focuses on the MSRV use case, and avoids mentioning "deprecation" explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambda-fairy @smoelius @est31