Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

huggingface[patch], pinecone[patch], fireworks[patch], mistralai[patch], voyageai[patch], togetherai[path]: convert Pydantic extras to literals #25384

Merged
merged 7 commits into from
Aug 14, 2024
Merged

huggingface[patch], pinecone[patch], fireworks[patch], mistralai[patch], voyageai[patch], togetherai[path]: convert Pydantic extras to literals #25384

merged 7 commits into from
Aug 14, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Aug 14, 2024 •
edited
Loading

Backwards compatible change that converts pydantic extras to literals which is consistent with pydantic 2 usage.

  • fireworks
  • voyage ai
  • mistralai
  • mistral ai
  • together ai
  • huggigng face
  • pinecone

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 1:27pm

@efriis efriis added the partner label Aug 14, 2024
@efriis efriis self-assigned this Aug 14, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 14, 2024
@eyurtsev eyurtsev changed the title convert more extras huggingface[patch], pinecone[patch], fireworks[patch], mistralai[patch], voyageai[patch], togetherai[path]: convert more extras Aug 14, 2024
@eyurtsev eyurtsev changed the title huggingface[patch], pinecone[patch], fireworks[patch], mistralai[patch], voyageai[patch], togetherai[path]: convert more extras huggingface[patch], pinecone[patch], fireworks[patch], mistralai[patch], voyageai[patch], togetherai[path]: convert Pydantic extras to literals Aug 14, 2024
@dosubot dosubot bot added Ɑ: embeddings Related to text embedding models module 🔌: fireworks Primarily related to Fireworks AI model intergrations 🔌: huggingface Primarily related to HuggingFace integrations 🔌: pinecone Primarily related to Pinecone vector store integration 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 14, 2024
@eyurtsev eyurtsev added the 0.3 prep Work done for 0.3 prep label Aug 14, 2024
@eyurtsev eyurtsev merged commit 5f5e8c9 into master Aug 14, 2024
64 checks passed
@eyurtsev eyurtsev deleted the eugene/fix_more_extras branch August 14, 2024 13:55
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
@eyurtsev @olgamurraft
huggingface[patch], pinecone[patch], fireworks[patch], mistralai[patc…
d0166ce 
…h], voyageai[patch], togetherai[path]: convert Pydantic extras to literals (langchain-ai#25384)

Backwards compatible change that converts pydantic extras to literals
which is consistent with pydantic 2 usage.

- fireworks
- voyage ai
- mistralai
- mistral ai
- together ai
- huggigng face
- pinecone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efriis efriis

Labels
0.3 prep Work done for 0.3 prep Ɑ: embeddings Related to text embedding models module 🔌: fireworks Primarily related to Fireworks AI model intergrations 🔌: huggingface Primarily related to HuggingFace integrations 🤖:improvement Medium size change to existing code to handle new use-cases partner 🔌: pinecone Primarily related to Pinecone vector store integration size:M This PR changes 30-99 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyurtsev @efriis