Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add ruff rules for error messages (EM) #26965

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 28, 2024

All auto-fixes

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 10:09pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: core Related to langchain-core labels Sep 28, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is is undesirable to have f-strings in error messages?

@efriis efriis self-assigned this Oct 3, 2024
@cbornet
Copy link
Collaborator Author

cbornet commented Oct 4, 2024

It comes from this rule: https://docs.astral.sh/ruff/rules/f-string-in-exception/

@efriis
Copy link
Member

efriis commented Oct 7, 2024

got it. works for me

@efriis efriis enabled auto-merge (squash) October 7, 2024 21:54
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 7, 2024
@efriis efriis merged commit d31ec88 into langchain-ai:master Oct 7, 2024
85 checks passed
@cbornet cbornet deleted the ruff-rules-em branch October 8, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants