Update PG Implementation #1948
Merged
Update PG Implementation #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarda
reviewed
Oct 1, 2024
| @@ -16,10 +16,10 @@ test: | |||
| EXIT_CODE=$$?; \ | |||
| make stop-postgres; \ | |||
| exit $$EXIT_CODE | |||
|
|
|||
| TEST ?= . | |||
| test_watch: | |||
| make start-postgres; \ | |||
There was a problem hiding this comment.
would it make sense to test on both versions of postgres (15 and 16)? or is it an overkill?
There was a problem hiding this comment.
hm - maybe a good idea
There was a problem hiding this comment.
I think better for sep PR though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LTree supports too small a subset of labels (especially pre-postgres 16) and provides very little benefits over text columns (only improves less common namespace listing operations)
Rewrite to use a regular text column with a btree here.