[11.x] Add generic type parameters for Eloquent\Builder in @param Tag to avoid PHPStan errors

[kayw-geek]

Currently, the @param tag for the Illuminate\Database\Eloquent\Builder class does not specify generic type parameters. As a result, PHPStan throws errors when implements the apply() method of Scope .

This PR adds the * generic type parameters to Illuminate\Database\Eloquent\Builder.

[ollieread]

@kayw-geek I've just tested this locally and PHPStan complains about the usage of *.

[kayw-geek]

@kayw-geek I've just tested this locally and PHPStan complains about the usage of *.

Can you provide a detailed error report or PHPStan playground? Theoretically, it should work.

[ollieread]

@kayw-geek I've just tested this locally and PHPStan complains about the usage of *.

Can you provide a detailed error report or PHPStan playground? Theoretically, it should work.

Hmm, it's only in very specific situations that it breaks, and it happens when there are several layered generics, which, I think, is an implementation and PHPStan specific thing, not this. Ignore me, sorry.

[taylorotwell]

I feel like this would apply to a huge number of other places in the framework? What PHPStan level?

[ollieread]

I feel like this would apply to a huge number of other places in the framework? What PHPStan level?

There are many places in the framework that could be updated with proper generics for PHPStan (I always use max), so I think you're right, this would be a bigger task.

@kayw-geek I use larastan which has stubs to cover this sort of thing.