Enhancement: Enable self_static_accessor fixer #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will await @nunomaduro's feedback here. I don't have a strong preference either way. I could see the argument for using static even if the class is final just in case the final is removed at some point. |
nunomaduro
approved these changes
Mar 17, 2023
|
Thank you, @nunomaduro and @taylorotwell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
self_static_accessorfixer for thelaravelpreset💁♂️ For reference, see https:/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.15.1/doc/rules/class_notation/self_static_accessor.rst.
I have noticed use of
staticinside classes declared asfinalinso perhaps it makes sense to enable the fixer for all users of the
laravelpreset instead of fixing these issues manually?