Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic Download of CSPICE Toolkit #3

Open
medley56 opened this issue Oct 7, 2024 · 0 comments
Open

Add Dynamic Download of CSPICE Toolkit #3

medley56 opened this issue Oct 7, 2024 · 0 comments

Comments

@medley56
Copy link
Collaborator

medley56 commented Oct 7, 2024

Context

This package relies on the CSPICE Toolkit (which includes MKSPK and MSOPCK) and those are currently packaged with the repo but this is not ideal and NAIF recommends against doing this. Ideally we want to be able to dynamically download the correct binaries and statically link them during package installation for use by the package.

Implementation

Via an "experimental feature", Poetry supports installation tasks via a build.py file along with your package. This is similar to a setup.py file but it doesn't have the same scope of responsibility as setup.py, such as requirements and metadata. We can put the installation logic here. My experiments so far indicate that build.py does work, including for publishing packages, but we will probably have to continue to support changes as Poetry gets updated.

Sadly, Poetry is being pretty slow in implementing this as a stable feature. I see signs on their github issues that development is progressing but it's still not documented outside of the issues themselves.

python-poetry/poetry#2740
python-poetry/poetry#8460
python-poetry/poetry#3576
python-poetry/poetry#8460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant