Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not install COPYING file #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kloczek
Copy link

@kloczek kloczek commented Jan 12, 2024

COPYING file is no essential and better is to leave it in source tree allowing packagers decide what to do with that file.

Remove of that file suggested in #116

COPYING file is no essential and better is to leave it in source tree allowing
packagers decide what to do with that file.

Remove of that file suggested in latchset#116

Signed-off-by: Tomasz Kłoczko <[email protected]>
@sarroutbi
Copy link
Collaborator

I am not sure this does not break GPL. For example, when distributing JOSE rpm package, the rpm has the COPYING file included:

$ rpm -ql jose-11-8.fc39.x86_64.rpm
...
/usr/share/licenses/jose
/usr/share/licenses/jose/COPYING
...

@kloczek
Copy link
Author

kloczek commented Jan 17, 2024

I am not sure this does not break GPL. For example, when distributing JOSE rpm package, the rpm has the COPYING file included:

I did not wrote anything about breaking something.
Provide COPYING file by Fedora package is part of te Fedora packaging policy.
MIT license do not require provide that file as part of installable resources. This is why package of the the distribution on which I'm working has only in spec file only

License:        MIT (https://spdx.org/licenses/MIT.html)

@sarroutbi
Copy link
Collaborator

Sorry, I meant Apache license. According to it (https://www.apache.org/licenses/LICENSE-2.0):

4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:

You must give any other recipients of the Work or Derivative Works a copy of this License;
...

So, IMHO, this PR should not be merged and COPYING file should be distributed

@eli-schwartz
Copy link
Contributor

As a pure aside: https://mesonbuild.com/Release-notes-for-1-1-0.html#the-project-function-now-supports-setting-the-project-license-files

If you bumped your minimum version of meson to 1.1.0, then you could set the license file in the project() function and meson could install it in combination with meson.install_dependency_manifest() -- or if you don't use install_dependency_manifest() it will automatically install for you when users define meson setup --licensedir=/usr/share/licenses/jose.

@sarroutbi
Copy link
Collaborator

As a pure aside: https://mesonbuild.com/Release-notes-for-1-1-0.html#the-project-function-now-supports-setting-the-project-license-files

If you bumped your minimum version of meson to 1.1.0, then you could set the license file in the project() function and meson could install it in combination with meson.install_dependency_manifest() -- or if you don't use install_dependency_manifest() it will automatically install for you when users define meson setup --licensedir=/usr/share/licenses/jose.

Hello @eli-schwartz : Thanks for clarifying. I guess this should be tracked in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants