-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some FreeBSD conditions #98
Conversation
Change build_machine to host_machine for freebsd specific configuration.
Allow building the test on a FreeBSD build host even if no "OpenSSL" since the base OpenSSL will suffice.
OPENSSL_init_ssl only exists since version 1.1.0.
Dependency on libcrypto neither necessary nor desirable if using the builtin openssl (it world require the ports version to be installed instead.)
Hello @hdholm. Thanks for PR. Changes LGTM. Please, could you rebase on top of the current tree to fix the conflicts? Thanks in advance |
Signed-off-by: Sergio Arroutbi Braojos <[email protected]>
Depend on host_machine rather than build_machine to account for potential cross compilation.
Look for the openSSL libs in /usr/local first.
Fix for OpenSSL 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments -- thank you for pushing this :).
Whatever in meson/FreeBSD was unhappy about the basic library dependency for libcrypto seems to have been fixed because it's working for me in all tests I've done in it's basic form. Also removing the version check since nothing should be using the wildly out of date openssl.
The CI checks are stalled on this, which I believe is fixed by PR #129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 💚!!
…private change is the right answer. I did not make changes to the depends method(s) since that seemed to make the Debian based builds very unhappy (couldn't find libcrypto) and everything else seems to generate reasonable pkg_config files without invoking method.
Hello @hdholm. Thanks for the PR. A new release of jose is being planned and we would like this change to be merged ... would you mind fixing the conflicts? Or do you prefer me to do it? I am OK with both. |
As conflict is easily fixable, I will sort it out myself. Thanks for your PR @hdholm. |
Signed-off-by: Sergio Arroutbi <[email protected]>
Thanks for taking care of it. It's been a very busy week. Just catching up on email now. |
Relatively small changes to check for host_machine vs. build_machine as the target to account for possible cross compilation. Additionally removes some explicit dependencies on OpenSSL for FreeBSD which required OpenSSL to be installed via pkg or ports rather than relying on the "built-in" OpenSSL version shipped by default. Consequently discovered that the issue-75 test depends on version 1.1.0 or higher of OpenSSL being installed on the build machine for OPENSSL_init_ssl, .so made that explicit in the dependency.