Desktop: Fixes #10562: Preserve table customization made on RTE #10927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a regression. I've created a simple table: 
And it converted it to HTML: 
|
Comment on lines
190
to
194
| // Deskotp app table have, by default, border-collapse style, | ||
| // so we need one more to know if the table is modified | ||
| const isModifiedRTETable = (tableNode) => { | ||
| return tableNode.style.length > 1; | ||
| } |
There was a problem hiding this comment.
Currently, this could break if the renderer package is updated to apply different default styles to tables. Here are some ideas to prevent regressions:
- Add a test that verifies that a table rendered with the latest version of the renderer package is converted back to Markdown (with
preserveNestedTables: true). - Would it be possible to check for the presence of specific style attributes? For example, convert to HTML if
['background-color', 'border-color', 'border']includes one of the style properties.
Thank you for working on this!
|
We might want to rethink the way the "resizing check" is implemented: The issue is that the only way to know if the column/row was resized is by checking each column and each row and comparing its values. |
laurent22
reviewed
Sep 13, 2024
| wasResized(tableNode) | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
We had this function - tableShouldBeHtml() which clearly tells if a table should be html or not. Wasn't it possible to extend this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10562
Summary
Tables created on RTE and modified would lose its configuration when the user opened the note on Markdown editor.
Now the values should be kept when the user toggles between the two editors.
To fix this I'm checking if some style properties exist that modify the table:
background-color: changes the background color of the cellfloat,margin-left,margin-right: changes the alignment of the tableI'm ignoring these properties (changing them doesn't preserve the table):
width,height: I think if we preserve the HTML table if they are modified we would have to convert even simple tables.border,cell spacing,cell padding: desktop has a default style that overrides the one set in the options, so even if set there is no visual change (should this be changed?)Testing
I added some tests on app-cli, trying to follow the pattern we already have there.