Desktop: Accessibility: Add ARIA information to the sidebar's notebook and tag list #11196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request:
aria-level=1
, a toplevel notebook hasaria-level=2
, a notebook with one parent notebook hasaria-level=3
.Additionally:
Remaining issues & future work
Testing plan
Screen recording comparison: NVDA + Windows
Screencast.from.2024-10-11.17-11-56.webm
Compare with before
Note: Previously, NVDA interacted with the note list in browse mode, due to its lack of a role. As such, NVDA handles the focus, rather than Joplin.
Screencast.from.2024-10-11.17-16-05.webm