Skip to content

Commit

Permalink
Resolve a couple of Github Action CI annoyances: (XRPLF#4413)
Browse files Browse the repository at this point in the history
* Set "fail-fast: false" so that multiple jobs in one workflow can
  finish independently. By default, if one job fails, other running jobs
  will be aborted, even if the other jobs are working fine and are
  almost done. This leads to wasted time and resources if the failure
  is, for example, OS specific, or due to a flaky unit test, and the
  failed job needs to be re-run, because all the jobs end up re-running.
* Put conditions back into the windows.yml job (manual, and for
  a specific branch name and that job). This prevents Github Actions
  from sending "No jobs were run" failure emails on every commit.
  • Loading branch information
ximinez authored and legleux committed Feb 22, 2023
1 parent dbe7583 commit e1c8b2b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/nix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ jobs:

test:
strategy:
fail-fast: false
matrix:
platform:
- ubuntu-latest
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,19 @@ name: windows
# then, we leave this tombstone as a reminder that we have tried (but failed)
# to write a reliable test for Windows.
# on: [push, pull_request]
on:
workflow_dispatch:
push:
branches:
- 'action'
paths:
- '.github/workflow/windows.yml'

jobs:

test:
strategy:
fail-fast: false
matrix:
generator:
- Visual Studio 16 2019
Expand Down

0 comments on commit e1c8b2b

Please sign in to comment.