Merge branch 'nodejs:main' into main

.eslintignore

@@ -5,8 +5,11 @@ test/fixtures
 test/message/esm_display_syntax_error.mjs
 tools/icu
 tools/lint-md/lint-md.mjs
+tools/github_reporter
 benchmark/tmp
 benchmark/fixtures
 doc/**/*.js
+doc/changelogs/CHANGELOG_v1*.md
+!doc/changelogs/CHANGELOG_v18.md
 !doc/api_assets/*.js
 !.eslintrc.js

.eslintrc.js

@@ -18,7 +18,7 @@ const hacks = [
  'eslint-plugin-jsdoc',
  'eslint-plugin-markdown',
  '@babel/eslint-parser',
- '@babel/plugin-syntax-import-assertions',
+ '@babel/plugin-syntax-import-attributes',
 ];
 Module._findPath = (request, paths, isMain) => {
  const r = ModuleFindPath(request, paths, isMain);
@@ -44,7 +44,7 @@ module.exports = {
  parserOptions: {
  babelOptions: {
  plugins: [
- Module._findPath('@babel/plugin-syntax-import-assertions'),
+ Module._findPath('@babel/plugin-syntax-import-attributes'),
  ],
  },
  requireConfigFile: false,
@@ -53,10 +53,10 @@ module.exports = {
  overrides: [
  {
  files: [
- 'test/es-module/test-esm-type-flag.js',
- 'test/es-module/test-esm-type-flag-alias.js',
  '*.mjs',
  'test/es-module/test-esm-example-loader.js',
+ 'test/es-module/test-esm-type-flag.js',
+ 'test/es-module/test-esm-type-flag-alias.js',
  ],
  parserOptions: { sourceType: 'module' },
  },
@@ -111,6 +111,22 @@ module.exports = {
  },
  ] },
  },
+ {
+ files: [
+ 'lib/internal/modules/**/*.js',
+ ],
+ rules: {
+ 'curly': 'error',
+ },
+ },
+ {
+ files: [
+ 'lib/internal/test_runner/**/*.js',
+ ],
+ rules: {
+ 'node-core/set-proto-to-null-in-object': 'error',
+ },
+ },
  ],
  rules: {
  // ESLint built-in rules
@@ -240,7 +256,6 @@ module.exports = {
  message: 'Use `globalThis.crypto`.',
  },
  ],
- 'no-return-await': 'error',
  'no-self-compare': 'error',
  'no-tabs': 'error',
  'no-template-curly-in-string': 'error',
@@ -345,5 +360,6 @@ module.exports = {
  WritableStream: 'readable',
  WritableStreamDefaultWriter: 'readable',
  WritableStreamDefaultController: 'readable',
+ WebSocket: 'readable',
  },
 };

.github/CODEOWNERS

@@ -11,17 +11,19 @@
 # tsc
 
 /.github/CODEOWNERS @nodejs/tsc
+/.github/PULL_REQUEST_TEMPLATE.md @nodejs/tsc
+/.github/ISSUE_TEMPLATE/* @nodejs/tsc
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
 /doc/contributing/*.md @nodejs/tsc
 /GOVERNANCE.md @nodejs/tsc
 /LICENSE @nodejs/tsc
 /onboarding.md @nodejs/tsc
 
-# website
-/doc/api_assets @nodejs/website
-/doc/template.html @nodejs/website
-/tools/doc @nodejs/website
+# nodejs.org website
+/doc/api_assets @nodejs/nodejs-website
+/doc/template.html @nodejs/nodejs-website
+/tools/doc @nodejs/web-infra
 
 # streams
 
@@ -57,6 +59,8 @@
 
 # tls/crypto
 
+/doc/api/crypto.md @nodejs/crypto
+/doc/api/webcrypto.md @nodejs/crypto
 /lib/crypto.js @nodejs/crypto
 /lib/internal/crypto/* @nodejs/crypto
 /lib/internal/tls/* @nodejs/crypto @nodejs/net
@@ -85,16 +89,16 @@
 
 # modules, including loaders
 
-/doc/api/esm.md @nodejs/modules @nodejs/loaders
-/doc/api/module.md @nodejs/modules @nodejs/loaders
-/doc/api/modules.md @nodejs/modules @nodejs/loaders
-/doc/api/packages.md @nodejs/modules @nodejs/loaders
-/lib/internal/bootstrap/realm.js @nodejs/modules @nodejs/loaders
-/lib/internal/modules/* @nodejs/modules @nodejs/loaders
-/lib/internal/process/esm_loader.js @nodejs/modules @nodejs/loaders
-/lib/internal/process/execution.js @nodejs/modules @nodejs/loaders
-/lib/module.js @nodejs/modules @nodejs/loaders
-/src/module_wrap* @nodejs/modules @nodejs/loaders @nodejs/vm
+/doc/api/esm.md @nodejs/loaders
+/doc/api/module.md @nodejs/loaders
+/doc/api/modules.md @nodejs/loaders
+/doc/api/packages.md @nodejs/loaders
+/lib/internal/bootstrap/realm.js @nodejs/loaders
+/lib/internal/modules/* @nodejs/loaders
+/lib/internal/process/esm_loader.js @nodejs/loaders
+/lib/internal/process/execution.js @nodejs/loaders
+/lib/module.js @nodejs/loaders
+/src/module_wrap* @nodejs/loaders @nodejs/vm
 
 # Node-API
 
@@ -146,6 +150,7 @@
 /lib/internal/main/test_runner.js @nodejs/test_runner
 /lib/internal/test_runner/* @nodejs/test_runner
 /lib/test.js @nodejs/test_runner
+/lib/test/reporters.js @nodejs/test_runner
 /test/parallel/test-runner-* @nodejs/test_runner
 
 # Single Executable Applications
@@ -169,3 +174,9 @@
 /.github/workflows/update-openssl.yml @nodejs/security-wg
 /.github/workflows/update-v8.yml @nodejs/security-wg @nodejs/v8-update
 /tools/dep_updaters/* @nodejs/security-wg
+
+# Web Standards
+/lib/internal/bootstrap/web/* @nodejs/web-standards
+/lib/internal/navigator.js @nodejs/web-standards
+/test/fixtures/wpt/ @nodejs/web-standards
+/test/wpt/ @nodejs/web-standards

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -27,7 +27,11 @@ body:
  - type: textarea
  attributes:
  label: What steps will reproduce the bug?
- description: Enter details about your bug, preferably a simple code snippet that can be run using `node` directly without installing third-party dependencies.
+ description: >
+ Enter details about your bug, preferably a simple code snippet that can
+ be run using `node` directly without installing third-party dependencies
+ or downloading code from the internet (i.e. no ZIP archive, no GitHub
+ repository, etc.).
  - type: textarea
  attributes:
  label: How often does it reproduce? Is there a required condition?

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,18 @@
 <!--
-Before submitting a pull request, please read
-https:/nodejs/node/blob/HEAD/CONTRIBUTING.md.
+Before submitting a pull request, please read:
 
-Commit message formatting guidelines:
-https:/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
+- the CONTRIBUTING guide at https:/nodejs/node/blob/HEAD/CONTRIBUTING.md
+- the commit message formatting guidelines at
+ https:/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.
 2. Update documentation if relevant.
 3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
 
+If you believe this PR should be highlighted in the Node.js CHANGELOG
+please add the `notable-change` label.
+
 Developer's Certificate of Origin 1.1
 
 By making a contribution to this project, I certify that:

.github/label-pr-config.yml

@@ -47,7 +47,7 @@ subSystemLabels:
  /^\w+\.md$/: doc
  # Different variants of Makefile and build files
  /^(?:tools\/)?(?:Makefile|BSDmakefile|create_android_makefiles)$/: build, needs-ci
- /^tools\/(?:install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
+ /^tools\/(?:install\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci
  /^vcbuild\.bat$/: build, windows, needs-ci
  /^(?:android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
  # More specific tools

.github/workflows/auto-start-ci.yml

@@ -34,7 +34,7 @@ jobs:
  --label 'request-ci' \
  --json 'number' \
  -t '{{ range . }}{{ .number }} {{ end }}' \
- --limit 100)
+ --limit 5)
  echo "numbers=$numbers" >> $GITHUB_OUTPUT
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -46,19 +46,19 @@ jobs:
  if: needs.get-prs-for-ci.outputs.numbers != ''
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+ - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  with:
  persist-credentials: false
 
  - name: Install Node.js
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
+ uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
  with:
  node-version: ${{ env.NODE_VERSION }}
 
- - name: Install node-core-utils
- run: npm install -g node-core-utils
+ - name: Install @node-core/utils
+ run: npm install -g @node-core/utils
 
- - name: Setup node-core-utils
+ - name: Setup @node-core/utils
  run: |
  ncu-config set username ${{ secrets.JENKINS_USER }}
  ncu-config set token "${{ secrets.GH_USER_TOKEN }}"

.github/workflows/build-tarball.yml

@@ -39,11 +39,11 @@ jobs:
  if: github.event.pull_request.draft == false
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+ - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@bd6b4b6205c4dbad673328db7b31b7fab9e241c0 # v4.6.1
+ uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Environment Information
@@ -57,19 +57,19 @@ jobs:
  mkdir tarballs
  mv *.tar.gz tarballs
  - name: Upload tarball artifact
- uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
+ uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
  with:
  name: tarballs
  path: tarballs
  test-tarball-linux:
  needs: build-tarball
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+ - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@bd6b4b6205c4dbad673328db7b31b7fab9e241c0 # v4.6.1
+ uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Environment Information
@@ -94,4 +94,4 @@ jobs:
  - name: Test
  run: |
  cd $TAR_DIR
- make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
+ make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9"

.github/workflows/build-windows.yml

@@ -34,15 +34,15 @@ jobs:
  if: github.event.pull_request.draft == false
  strategy:
  matrix:
- windows: [windows-2019, windows-2022]
+ windows: [windows-2022]
  fail-fast: false
  runs-on: ${{ matrix.windows }}
  steps:
- - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+ - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@bd6b4b6205c4dbad673328db7b31b7fab9e241c0 # v4.6.1
+ uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Install deps

.github/workflows/close-stale-feature-requests.yml

@@ -48,7 +48,7 @@ jobs:
  close-issue-message: ${{ env.CLOSE_MESSAGE }}
  stale-issue-message: ${{ env.WARN_MESSAGE }}
  only-labels: feature request
- exempt-pr-labels: never-stale
+ exempt-issue-labels: never-stale
  # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
  operations-per-run: 500
  remove-stale-when-updated: true

.github/workflows/comment-labeled.yml

@@ -13,7 +13,7 @@ env:
  NOTABLE_CHANGE_MESSAGE: |
  The https:/nodejs/node/labels/notable-change label has been added by @${{ github.actor }}.
 
- Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.
+ Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the _Other Notable Changes_ section.
 
 permissions:
  contents: read

.github/workflows/commit-lint.yml

@@ -17,13 +17,13 @@ jobs:
  run: |
  echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
  echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
- - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+ - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  with:
  fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
  persist-credentials: false
  - run: git reset HEAD^2
  - name: Install Node.js
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
+ uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
  with:
  node-version: ${{ env.NODE_VERSION }}
  - name: Validate commit message

.github/workflows/commit-queue.yml

@@ -58,7 +58,7 @@ jobs:
  if: needs.get_mergeable_prs.outputs.numbers != ''
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
+ - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
  with:
  # Needs the whole git history for ncu to work
  # See https:/nodejs/node-core-utils/pull/486
@@ -71,18 +71,18 @@ jobs:
 
  # Install dependencies
  - name: Install Node.js
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
+ uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
  with:
  node-version: ${{ env.NODE_VERSION }}
- - name: Install node-core-utils
- run: npm install -g node-core-utils@latest
+ - name: Install @node-core/utils
+ run: npm install -g @node-core/utils
 
  - name: Set variables
  run: |
  echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
  echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
 
- - name: Configure node-core-utils
+ - name: Configure @node-core/utils
  run: |
  ncu-config set branch ${GITHUB_REF_NAME}
  ncu-config set upstream origin