Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In PHP 8.2.1, I get several of the following messages: "User Deprecated: Method "JsonSerializable::jsonSerialize()" might add "mixed" as a native return type declaration in the future." #506

Closed
mrunkel opened this issue Apr 7, 2023 · 1 comment
Closed

In PHP 8.2.1, I get several of the following messages: "User Deprecated: Method "JsonSerializable::jsonSerialize()" might add "mixed" as a native return type declaration in the future." #506

mrunkel opened this issue Apr 7, 2023 · 1 comment

Comments

@mrunkel
Copy link
Contributor

mrunkel commented Apr 7, 2023

It looks like the attribute #[\ReturnTypeWillChange] doesn't supress this message.

I went ahead and added the appropriate return types, and the message is removed.

PR coming in a few minutes.
mrunkel added a commit to mrunkel/php-jira-rest-client that referenced this issue Apr 7, 2023
@mrunkel
Add return types to jsonSerialize to surpress deprecation message. Fi…
96626e6 
…xes issue lesstif#506.
@mrunkel mrunkel mentioned this issue Apr 7, 2023
Merged
mrunkel added a commit to mrunkel/php-jira-rest-client that referenced this issue Apr 7, 2023
@mrunkel
Fix pre-existing style issue, rewrite if block with empty body. Fixes…
051f380 
… issue lesstif#506.
lesstif pushed a commit that referenced this issue Apr 16, 2023
@mrunkel
Add return types to jsonSerialize to suppress deprecation message. (#507
5fe666f 
)

* Add return types to jsonSerialize to surpress deprecation message.   Fixes issue #506.

* Fix pre-existing style issue, rewrite if block with empty body.  Fixes issue #506.

---------

Co-authored-by: Marc Runkel <[email protected]>
@lesstif
Copy link
Owner

lesstif commented May 15, 2023

fixed by #507

@lesstif lesstif closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lesstif @mrunkel