Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA: Run all CA package tests in parallel #7438

Merged
merged 2 commits into from
Apr 17, 2024
Merged

CA: Run all CA package tests in parallel #7438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26b58d
Run CA tests in parallel
pgporada Apr 17, 2024
71a79de
More parallel
pgporada Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ca/ca_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import (
)

func TestImplementation(t *testing.T) {
t.Parallel()
test.AssertImplementsGRPCServer(t, &certificateAuthorityImpl{}, capb.UnimplementedCertificateAuthorityServer{})
}

Expand Down Expand Up @@ -277,6 +278,7 @@ func setup(t *testing.T) *testCtx {
}

func TestSerialPrefix(t *testing.T) {
t.Parallel()
testCtx := setup(t)

_, err := NewCertificateAuthorityImpl(
Expand Down Expand Up @@ -329,6 +331,7 @@ type TestCertificateIssuance struct {
}

func TestIssuePrecertificate(t *testing.T) {
t.Parallel()
testCases := []struct {
name string
csr []byte
Expand Down Expand Up @@ -439,6 +442,7 @@ func issueCertificateSubTestValidityUsesCAClock(t *testing.T, i *TestCertificate

// Test failure mode when no issuers are present.
func TestNoIssuers(t *testing.T) {
t.Parallel()
testCtx := setup(t)
sa := &mockSA{}
_, err := NewCertificateAuthorityImpl(
Expand All @@ -465,6 +469,7 @@ func TestNoIssuers(t *testing.T) {

// Test issuing when multiple issuers are present.
func TestMultipleIssuers(t *testing.T) {
t.Parallel()
testCtx := setup(t)
sa := &mockSA{}
ca, err := NewCertificateAuthorityImpl(
Expand Down Expand Up @@ -511,6 +516,7 @@ func TestMultipleIssuers(t *testing.T) {
}

func TestProfiles(t *testing.T) {
t.Parallel()
ctx := setup(t)
test.AssertEquals(t, len(ctx.certProfiles), 2)

Expand Down Expand Up @@ -679,6 +685,7 @@ func TestProfiles(t *testing.T) {
}

func TestECDSAAllowList(t *testing.T) {
t.Parallel()
req := &capb.IssueCertificateRequest{Csr: ECDSACSR, RegistrationID: arbitraryRegID}

// With allowlist containing arbitraryRegID, issuance should come from ECDSA issuer.
Expand Down Expand Up @@ -711,6 +718,7 @@ func TestECDSAAllowList(t *testing.T) {
}

func TestInvalidCSRs(t *testing.T) {
t.Parallel()
testCases := []struct {
name string
csrPath string
Expand Down Expand Up @@ -802,6 +810,7 @@ func TestInvalidCSRs(t *testing.T) {
}

func TestRejectValidityTooLong(t *testing.T) {
t.Parallel()
testCtx := setup(t)
sa := &mockSA{}
ca, err := NewCertificateAuthorityImpl(
Expand Down Expand Up @@ -905,6 +914,7 @@ func makeSCTs() ([][]byte, error) {
}

func TestIssueCertificateForPrecertificate(t *testing.T) {
t.Parallel()
testCtx := setup(t)
sa := &mockSA{}
ca, err := NewCertificateAuthorityImpl(
Expand Down Expand Up @@ -975,6 +985,7 @@ func TestIssueCertificateForPrecertificate(t *testing.T) {
}

func TestIssueCertificateForPrecertificateWithSpecificCertificateProfile(t *testing.T) {
t.Parallel()
testCtx := setup(t)
sa := &mockSA{}
ca, err := NewCertificateAuthorityImpl(
Expand Down Expand Up @@ -1096,6 +1107,7 @@ func (m *getCertErrorSA) GetCertificate(ctx context.Context, req *sapb.Serial, _
}

func TestIssueCertificateForPrecertificateDuplicateSerial(t *testing.T) {
t.Parallel()
testCtx := setup(t)
sa := &dupeSA{}
ca, err := NewCertificateAuthorityImpl(
Expand Down Expand Up @@ -1190,6 +1202,7 @@ func TestIssueCertificateForPrecertificateDuplicateSerial(t *testing.T) {
}

func TestGenerateSKID(t *testing.T) {
t.Parallel()
key, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
test.AssertNotError(t, err, "Error generating key")

Expand Down