Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid NEON instructions for armv6 Raspberry Pi's #49

Merged
merged 28 commits into from
Mar 1, 2024

Conversation

bjia56
Copy link
Collaborator

@bjia56 bjia56 commented Feb 28, 2024

Fixes how flags are passed to Zig so proper armv6 code is generated by the compiler.

Attempts to resolve issues reported in lexiforest/curl_cffi#124

@bjia56
Copy link
Collaborator Author

bjia56 commented Mar 1, 2024

@yifeikong can you please try running the latest build's artifacts on your armv6 and see if the issue is resolved?

@bjia56 bjia56 changed the title Disable NEON for armv6 Raspberry Pi's Fix invalid NEON instructions for armv6 Raspberry Pi's Mar 1, 2024
@perklet
Copy link
Collaborator

perklet commented Mar 1, 2024

Works like a charm.

@bjia56
Copy link
Collaborator Author

bjia56 commented Mar 1, 2024

I'm going to clear the github actions cache later today, before merging this in. Existing caches may have bad code, so that should get correct builds going forward

@bjia56 bjia56 marked this pull request as ready for review March 1, 2024 19:52
@bjia56 bjia56 merged commit 3f8ee08 into lexiforest:main Mar 1, 2024
9 checks passed
@bjia56 bjia56 deleted the armv6-fixes branch March 1, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants